= FDO RFC 6 - Enhance WMS Command API =

This page contains a request for comments document (RFC) for the FDO Open Source project.  
More FDO RFCs can be found on the [wiki:FDORfcs RFCs] page.

== Status == 
 
||RFC Template Version||1.0|| 
||Submission Date||Jul 20, 2007 ||
||Last Modified||Maggie Yang [[Timestamp]]||
||Author||Maggie Yang||
||RFC Status||Draft||
||Implementation Status||Under Development ||
||Proposed Milestone||3.3.0.0||
||Assigned PSC guide(s)||Greg Boone||
||'''Voting History'''||TBD||
||+1|| ||
||+0|| ||
||-0|| ||
||-1|| ||
 
== Overview ==

In the current design of the OSGeo OGC FDO WMS Provider(s), no mechanism exists to allow a client to retrieve all supported CRS/style names supported by specific WMS layer, neither for image format types supported by WMS service.

In order to resolve this issue, the WMS providers should be enhanced to add 3 new commands for retrieving all supported image format, style and CS information from WMS service individually.

== Proposed Solution ==

In order not to impact the standard FDO command interface, we plan just adding those 3 commands interface for WMS only. Thus, we also declare a new enum type: WmsCommandType for WMS provider.
The following shows the new enumeration.
{{{
// This number is defined so our custom command would not clash with other
// custom provider commands.
#define WMS_FIRST_PROVIDER_COMMAND 1800

/// \brief
/// The FdoWmsCommandType enumeration defines the list of WMS Provider specific commands.
enum FdoWmsCommandType{

    /// Represents the GetImageFormats command.
    FdoWmsCommandType_GetImageFormats =  FdoCommandType_FirstProviderCommand + WMS_FIRST_PROVIDER_COMMAND,
    FdoWmsCommandType_GetFeatureClassStyles,
    FdoWmsCommandType_GetFeatureClassCRSNames
};
}}}

3 new commands will be added to the FDO WMS Providers, individually for getting image formats, styles and CS names. 

=== Get Image Formats Command ===

{{{
class FdoWmsIGetImageFormats: public FdoICommand
{
public:
    /// \brief
    /// Executes the GetImageFormats command and returns a 
    /// FdoStringCollection, which contains all image formats supported by WMS service.
    /// 
    /// \return
    /// Returns the image format collection supported by WMS service
     /// 
    FDO_API virtual FdoStringCollection * Execute() = 0;
};

}}}

=== Get Styles Command ===

''NOTE: A FeatureClass is an FDO concept. One feature class corresponds to one layer name in the originating WMS service. We use feature class, instead of layer here, in order to remain consistant with the feature concepts defined in the FDO API.''

{{{
class FdoWmsIGetFeatureClassStyles : public FdoICommand
{
public:
    /// \brief
    /// Gets the name of the feature class to get all supported styles. 
    /// 
    /// \return
    /// Returns the featuer class name
    /// 
    FDO_API virtual FdoString* GetFeatureClassName() = 0;

    /// \brief
    /// Sets the name of the feature class to get all supported styles.
    /// This function is mandatory; if not specified, 
    /// execution of the command will throw exception. 
    ///
    /// \param value 
    /// Input the feature class name
    /// 
    /// \return
    /// Returns nothing
    /// 
    FDO_API virtual void SetFeatureClassName(FdoString* value) = 0;

    /// \brief
    /// Executes the GetFeatureClassStyles command and returns a 
    /// FdoStringCollection, which contains all styles supported by specific feature class
    /// and all styles supported by its ancestors, because WMS service supports Style 
    /// declarations are inherited by child Layers. 
    /// 
    /// \return
    /// Returns the styles collection supported by specific feature class
    /// 
    FDO_API virtual FdoStringCollection * Execute() = 0;
};

}}}

=== Get CRS Names Command ===

''NOTE: A FeatureClass is an FDO concept. One feature class corresponds to one layer name in the originating WMS service. We use feature class, instead of layer here, in order to remain consistant with the feature concepts defined in the FDO API.''

{{{
class FdoWmsIGetFeatureClassCRSNames: public FdoICommand
{
public:
    /// \brief
    /// Gets the name of the FeatureClass to get all supported CRS names. 
    /// 
    /// \return
    /// Returns the FeatureClass name
    /// 
    FDO_API virtual FdoString* GetFeatureClassName() = 0;

    /// \brief
    /// Sets the name of the FeatureClass to get all supported CRS names.
    /// This function is mandatory; if not specified, 
    /// execution of the command will throw exception. 
    ///
    /// \param value 
    /// Input the FeatureClass name
    /// 
    /// \return
    /// Returns nothing
    /// 
    FDO_API virtual void SetFeatureClassName(FdoString* value) = 0;

    /// \brief
    /// Executes the GetCRSNames command and returns a 
    /// FdoStringCollection, which contains entire CRS names supported by specific feature class.
    /// and all CRS names supported by its ancestors, because WMS service supports CRS
    /// declarations are inherited by child Layers. 
    /// 
    /// \return
    /// Returns the CRS name collection supported by the specific feature class.
    /// 
    FDO_API virtual FdoStringCollection * Execute() = 0;
};

}}}

== Implications ==

This change will not cause any side-effects, nor any compatibility problems.

== Test Plan ==

Existing unit tests will be expanded to test those changes. 

== Funding/Resources ==

Autodesk to provide resources / funding to update the WMS provider.