Opened 12 years ago
Last modified 12 years ago
#1803 closed defect
GRASS 6.4.3RC1 on Win 7: grass64.bat fails due to UNIX line endings in Init.bat — at Initial Version
Reported by: | msieczka | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | 6.4.3 |
Component: | Startup | Version: | 6.4.3 RCs |
Keywords: | Init.bat, CRLF, wingrass | Cc: | grass-dev@… |
CPU: | x86-64 | Platform: | MSWindows 7 |
Description
There's a following error at GRASS 6.4.3RC1 startup in text mode on Win 7 64bit:
C:\>"C:\Program Files (x86)\GRASS GIS 6.4.3RC1\grass64.bat" -text The system cannot find the batch label specified - aftertextcheck
The problem is in the etc\Init.bat where the "aftertextcheck" label is used - looks like Windows expects "\r\n" at the end of the label name rather than "\n".
Are the Windows builds done on Linux? If so, I guess the root cause is eol-style=native on lib/init/init.bat in the GRASS repo. The solution would be to set eol-style=CRLF, or maybe to tweak the makefile to run tr/unix2dos/... on etc/Init.bat.
Opinions?
There are plenty of *.bat with LF instead of CRLF in the GRASS installation dir. Shouldn't they all have CRLF line endings?:
$ cd '/c/Program Files (x86)/GRASS GIS 6.4.3RC1' $ find . -type f -iname '*.bat' -print0 | xargs -0 grep -Ulv $'\r' | wc -l 112