Changes between Version 44 and Version 45 of HowToContribute
- Timestamp:
- 04/12/20 14:45:41 (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
HowToContribute
v44 v45 18 18 The Trac ticket system is the best way to submit your code contributions if you don't have write access to SVN, and (even for those with write access) the preferred way to submit more radical changes for general review. See for example trac ticket #33. 19 19 * Submit your code and documentation patches [http://trac.osgeo.org/grass/newticket here]. 20 * [http://grass.osgeo.org/wiki/Patches How to create a patch] - they should be generated versus the latest development SVN (trunk).20 * [http://grass.osgeo.org/wiki/Patches How to create a patch] - they should be generated versus the latest development ("master" in !GitHub). 21 21 22 22 '''Code quality:''' Check your code according to GRASS GIS [wiki:Submitting Submitting rules and guide list]. … … 58 58 * New commands stored in the GRASS Addons repository should be also added as link to the [https://grasswiki.osgeo.org/wiki/AddOns Wiki list of tools] and placed in the appropriate directory hierarchy. 59 59 60 === Setting up the new SVNwrite access after acceptance ===60 === Setting up your write access after acceptance === 61 61 62 Once SVN access is granted, the requester's "osgeo_id" will be enabled.63 The GRASS-PSC chair (currently Markus Neteler) and other developers will add this "osgeo_id" to the list of enabled accounts in the OSGeo LDAP authentication system ([https://www.osgeo.org/cgi-bin/auth/ldap_group.py?group=grass here] for GRASS-SVN and [https://www.osgeo.org/cgi-bin/auth/ldap_group.py?group=grass_addons here] for GRASS-Addons-SVN; requires authentication).62 Once the git repo access is granted, the requester's !GitHub ID will be enabled by either the GRASS-PSC chair (currently Markus Neteler) and other core developers. 63 Then clone the source code from !GitHub. 64 64 65 65 '''Important:''' Contributions have to follow the [wiki:Submitting] code rules. … … 69 69 * If you contribute own code: See [wiki:Submitting Submitting - GRASS GIS Addons] 70 70 * If you want to modify existing code: [wiki:DownloadSource Get the source code] and Happy hacking :) 71 * If you want to suggest changes or a source code patch, please submit the change as "diff" and not the full modified file. See [wiki:HowToSVN#LocalDiffs HowToSVN Creating local diffs] 72 * Consider to subscribe to the [http://lists.osgeo.org/mailman/listinfo/grass-commit grass-commit] mailing list which distributes GRASS-SVN commit differences for real-time code review. 71 * If you want to suggest changes or a source code patch, please submit the change as "diff" and not the full modified file. See [wiki:HowToSVN#LocalDiffs HowToGit Creating local diffs] 72 * Consider to subscribe to the [http://lists.osgeo.org/mailman/listinfo/grass-commit grass-commit] mailing list which distributes GRASS-git commit differences for real-time code review. 73 73 74 === Coding standards and code style === 74 75 75 Check your code against the rules defined in the document [wiki:Submitting]. This ensures a smooth integration into the standard GRASS code base and avoids portability problems.76 Check your code against the rules defined in the document [wiki:Submitting]. This ensures a smooth integration into the standard GRASS GIS code base and avoids portability problems. 76 77 77 78 === And after submission of an Addon? ===