| 1 | |
| 2 | = !MapGuide RFC 178 - Toggle-able feature bounds in Layer Definition = |
| 3 | |
| 4 | This page contains a change request (RFC) for the !MapGuide Open Source project. |
| 5 | More !MapGuide RFCs can be found on the [wiki:MapGuideRfcs RFCs] page. |
| 6 | |
| 7 | == Status == |
| 8 | |
| 9 | ||RFC Template Version||(1.0)|| |
| 10 | ||Submission Date||30 Jan 2020|| |
| 11 | ||Last Modified||30 Jan 2020|| |
| 12 | ||Author||Jackie Ng|| |
| 13 | ||RFC Status||ready for review|| |
| 14 | ||Implementation Status||pending|| |
| 15 | ||Proposed Milestone||4.0|| |
| 16 | ||Assigned PSC guide(s)||(when determined)|| |
| 17 | ||'''Voting History'''||(vote date)|| |
| 18 | ||+1|||| |
| 19 | ||+0|||| |
| 20 | ||-0|||| |
| 21 | ||-1|||| |
| 22 | ||no vote|| || |
| 23 | |
| 24 | == Overview == |
| 25 | |
| 26 | This RFC proposes to make the bounds information of `QUERYMAPFEATURES` results toggle-able from the Layer Definition |
| 27 | |
| 28 | == Motivation == |
| 29 | |
| 30 | Bounding box information for each feature is included for every selected feature as part of a `QUERYMAPFEATURES` response. |
| 31 | |
| 32 | However, like certain feature attributes, the bounding box of any feature may be considered information that one does not want to return back to the requesting viewer. |
| 33 | |
| 34 | There is currently no means to toggle whether bounding boxes should be returned or not. It is currently always being returned. |
| 35 | |
| 36 | == Proposed Solution == |
| 37 | |
| 38 | Introduce a new `LayerDefinition-4.0.0` schema that includes a new `IncludeFeatureBounds` element. |
| 39 | |
| 40 | As we're introducing a new LayerDefinition schema version, we'll also take this opportunity to also fix #985 as well by fixing up the data type. |
| 41 | |
| 42 | Update the MdfModel Layer Definition classes to handle these element changes and use this flag to determine whether to include bounding box for every selected feature. This flag will default to true to preserve current behavior in older versions. An author must explicitly set this flag to false to omit bounding box information. |
| 43 | |
| 44 | Update the AJAX viewer to have the selection panel to gracefully operate in the absence of bounding box data for a selected feature. |
| 45 | |
| 46 | == Implications == |
| 47 | |
| 48 | None |
| 49 | |
| 50 | == Test Plan == |
| 51 | |
| 52 | Add MdfModel test to verify this new flag is being properly read and set for `MgLayer` and survives round-tripping when serialized/deserialized. |
| 53 | |
| 54 | Verify zoom to selected feature in AJAX viewer does nothing when the layer flag is set to false. |
| 55 | |
| 56 | Verify zoom to selected feature in AJAX viewer zooms to the feature when the layer flag is set to true. |
| 57 | |
| 58 | == Funding / Resources == |
| 59 | |
| 60 | Community |