Opened 5 years ago
Closed 5 years ago
#4596 closed defect (fixed)
The script to generate nation_script_load.sh is missing a trailing quote
| Reported by: | llimllib | Owned by: | robe |
|---|---|---|---|
| Priority: | medium | Milestone: | PostGIS 3.0.1 |
| Component: | tiger geocoder | Version: | 2.5.x -- EOL |
| Keywords: | tiger geocoder | Cc: |
Description
The script that generates nation_script_load.sh is missing a trailing comma at the end of this line:
https://github.com/postgis/postgis/blob/master/extras/tiger_geocoder/tiger_loader_2019.sql#L315
As a result, it generates an invalid script and the user manually has to insert a quote there.
I would be happy to generate a PR, but somebody would need to tell me how to do so, I'm unfamiliar with your dev process and it seems pretty different from a normal github process.
Change History (7)
comment:1 by , 5 years ago
| Summary: | The script to generate nation_script_load.sh is missing a trailing comma → The script to generate nation_script_load.sh is missing a trailing quote |
|---|
comment:2 by , 5 years ago
| Component: | postgis → tiger geocoder |
|---|---|
| Owner: | changed from to |
comment:3 by , 5 years ago
| Milestone: | PostGIS 2.5.4 → PostGIS 3.0.1 |
|---|
comment:4 by , 5 years ago
comment:7 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
you can do a github pull request is fine or a diff patch. Whatever you prefer.