fdo select command does not escape aliases

[jng]

For SQL Server, when you specify an alias via FdoISelect::SetAlias() the alias itself is not being escaped (with [ and ] for SQL Server) as part of the SQL that the fdo select command builds up for execution.

An easy way to test is to pass in a reserved keyword (eg. primary) as the alias. The select command when executed, will throw an error "Incorrect syntax near the keyword <your alias name>"

[jng]

Just to give extra context:

I was doing a fdo join select using "primary" as the alias. I added a selection of computed identifiers in the form of primary.propertyName.

So either the alias, or the computed identifiers are not being escaped properly by the command.

[romicadascalescu]

Date: 2011-12-01 07:53:05 -0800 (Thu, 01 Dec 2011) New Revision: 6319

Modified:

trunk/Providers/GenericRdbms/Src/Fdo/Other/FdoRdbmsSQLCommand.cpp trunk/Providers/GenericRdbms/Src/SQLServerSpatial/Fdo/FdoRdbmsSqlServerProcessors.cpp

Log: Ticket #760 & #799 Improve SQL Server Spatial

• avoid flushing cached schema when stored procedures are called
• added double quotes for aliases in select command