Opened 12 years ago

Closed 10 years ago

#1686 closed enhancement (fixed)

v.mkgrid should offer breaks option for vertical lines too

Reported by: marisn Owned by: grass-dev@…
Priority: normal Milestone: 7.0.0
Component: Vector Version: svn-releasebranch70
Keywords: v.mkgrid Cc:
CPU: Unspecified Platform: Unspecified

Description

Issue mentioned in user ML by Hamish.

Design decision needed - should breaks be used for both horizontal and vertical breaks or it should be renamed to h_breaks and v_breaks?

Original message: 20deg reprojected grid lines are a bit ugly, apparently we need to extend the v.mkgrid breaks= option to work on vertical lines as well as the horizontal ones. http://lists.osgeo.org/pipermail/grass-user/2012-July/065214.html

Image displaying the issue: http://lists.osgeo.org/pipermail/grass-user/attachments/20120702/066007f4/attachment.png

Attachments (4)

mkgrid.diff (3.4 KB ) - added by lucadelu 10 years ago.
patch for vertical breaks
v_mkgrid_sinusoidal1.jpg (30.1 KB ) - added by lucadelu 10 years ago.
screenshot about new v.mkgrid behavior with vertical breaks
v_mkgrid_sinusoidal_zoom.jpg (12.8 KB ) - added by lucadelu 10 years ago.
screenshot about new v.mkgrid behavior with vertical breaks, zoom in
eu_laea_grid_reprojected_in_LL.jpg (243.7 KB ) - added by neteler 10 years ago.
v.mkgrid result generated in EPSG 3035, then reprojected to LatLong

Download all attachments as: .zip

Change History (11)

in reply to:  description ; comment:1 by neteler, 10 years ago

Keywords: v.mkgrid added; mkgrid removed

Replying to marisn: ...

20deg reprojected grid lines are a bit ugly, apparently we need to extend the v.mkgrid breaks= option to work on vertical lines as well as the horizontal ones. http://lists.osgeo.org/pipermail/grass-user/2012-July/065214.html

Image displaying the issue: http://lists.osgeo.org/pipermail/grass-user/attachments/20120702/066007f4/attachment.png

Anyone able to extend the breaks to vertical lines in v.mkgrid? Thanks...

by lucadelu, 10 years ago

Attachment: mkgrid.diff added

patch for vertical breaks

by lucadelu, 10 years ago

Attachment: v_mkgrid_sinusoidal1.jpg added

screenshot about new v.mkgrid behavior with vertical breaks

by lucadelu, 10 years ago

screenshot about new v.mkgrid behavior with vertical breaks, zoom in

in reply to:  1 ; comment:2 by lucadelu, 10 years ago

Replying to neteler:

Anyone able to extend the breaks to vertical lines in v.mkgrid? Thanks...

I added breaks to vertical lines to v.mkgrid, please check the attached patch.

In the screenshots you can see:

  • red lines: old behavior of v.mkgrid
  • blue lines: new behavior of v.mkgrid with default breaks value (3)
  • green lines: new behavior of v.mkgrid with breaks value 30

in reply to:  2 comment:3 by lucadelu, 10 years ago

Replying to lucadelu:

I added breaks to vertical lines to v.mkgrid, please check the attached patch.

In the screenshots you can see:

  • red lines: old behavior of v.mkgrid
  • blue lines: new behavior of v.mkgrid with default breaks value (3)
  • green lines: new behavior of v.mkgrid with breaks value 30

I committed the changes in r61552. Please try it

It should be backported to release branch

by neteler, 10 years ago

v.mkgrid result generated in EPSG 3035, then reprojected to LatLong

comment:4 by neteler, 10 years ago

Version: unspecifiedsvn-releasebranch70

Tested -l ok, thanks for the fixes and improvements. See attached screenshot of a v.mkgrid result generated in EPSG 3035, then reprojected to Latlong EPSG 4326.

comment:5 by neteler, 10 years ago

Note: this vertex densification should also be added to v.proj

in reply to:  5 comment:6 by neteler, 10 years ago

Replying to neteler:

Note: this vertex densification should also be added to v.proj

Thanks to Markus Metz that got implemented in v.proj in r63307 (trunk).

comment:7 by neteler, 10 years ago

Resolution: fixed
Status: newclosed

All implemented, working fine. Closing.

Note: See TracTickets for help on using tickets.