#2059 closed enhancement (fixed)
WorldView2 relative spectral response data for i.atcorr
Reported by: | Nikos Alexandris | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | 7.2.1 |
Component: | Imagery | Version: | svn-trunk |
Keywords: | i.atcorr, worldview2 | Cc: | |
CPU: | Unspecified | Platform: | Unspecified |
Description
Attached .csv file, hopefully correctly formatted. The source for the data was: http://www.orfeo-toolbox.org/doxygen/otbWorldView2ImageMetadataInterface_8cxx_source.html, line 918 and beyond.
Attachments (7)
Change History (37)
follow-up: 2 comment:1 by , 11 years ago
Keywords: | sensors csv band filter removed |
---|---|
Version: | unspecified → svn-trunk |
follow-up: 4 comment:2 by , 11 years ago
Replying to neteler:
Would you mind to provide the spectral data as a patch for i.atcorr? For instructions, see http://svn.osgeo.org/grass/grass/trunk/imagery/i.atcorr/README
Yes Markus, that's what it is already. Just need a confirmation from someone.
by , 11 years ago
Attachment: | wv2_relative_spectral_response_data_for_i.atcorr.csv added |
---|
WorldView2 Relative Spectral Responce data for i.atcorr
comment:3 by , 11 years ago
File re-attached. During some "tr" operation in shell, too many commas got in the header line (in the firstly attached file).
comment:4 by , 11 years ago
Replying to nikosa:
Replying to neteler:
Would you mind to provide the spectral data as a patch for i.atcorr? For instructions, see http://svn.osgeo.org/grass/grass/trunk/imagery/i.atcorr/README
Yes Markus, that's what it is already. Just need a confirmation from someone.
If the .csv is fine, I can also try to alter the other files (Iwave.cpp, Iwave.h, GeomCond.cpp and GeomCond.h). Not now though...
by , 11 years ago
Attachment: | worldview2_for_i.atcorr.diff added |
---|
Patch adding support for WorldView2 in i.atcorr
comment:6 by , 11 years ago
It does not work...
GeomCond.cpp: In member function ‘void GeomCond::print()’: GeomCond.cpp:436:2: error: too many initializers for ‘const string [16] {aka const std::basic_string<char> [16]}’ make: *** [OBJ.x86_64-unknown-linux-gnu/GeomCond.o] Error 1
Any help?
comment:7 by , 11 years ago
Almost there... I think. I forgot to edit one table in the html file and, after doing so, it does not compile anymore although it did withouth the changes in the html file.
/osgeo/src/grass7_trunk/dist.x86_64-unknown-linux-gnu/docs/html/i.atcorr.html:240:0: Error (KeyError(None,)): <tr> make: *** [/osgeo/src/grass7_trunk/dist.x86_64-unknown-linux-gnu/docs/man/man1/i.atcorr.1] Error 1 rm i.atcorr.tmp.html
comment:8 by , 11 years ago
Typically inexperienced and in a hurry. I forgot to remove something... It compiles here now :-)
by , 11 years ago
Attachment: | worldview2_for_i.atcorr.3.diff added |
---|
Latest diff for adding WorldView2 support in i.atcorr
by , 11 years ago
Attachment: | worldview2_for_i.atcorr.4.diff added |
---|
Updated description of band ranges from the official source
follow-up: 10 comment:9 by , 11 years ago
Apologies for abusing the platform -- I will try to be more patient before posting. I don't (didn't) know what the actual implications are when posting a comment here. If I did any harm, please, let me know if there is a way to correct it.
Also, how can I post a new comment and at the same time attach a file? Possible?
It seems that I picked the wrong "number" that concern (only) the description of the bandwidths for WV-2 (from http://www.landinfo.com/WorldView2.htm). Updated now from the official source (latest attached file).
by , 11 years ago
Attachment: | worldview2_quickbird2_for_i.atcorr.diff added |
---|
Extending support for QuickBird2 (on top of WorldView2)
comment:10 by , 11 years ago
Replying to nikosa:
Also, how can I post a new comment and at the same time attach a file? Possible?
I think that only works when you are creating a new ticket. Otherwise it has to be done in two steps.
regards, Hamish
comment:13 by , 11 years ago
Back to this,
QuickBird2 samples available from GLCF: http://glcf.umd.edu/data/quickbird/, e.g. I recently used some from ftp://ftp.glcf.umd.edu/glcf/QuickBird/02NOV21044347-X2AS_R1C1-000000185940_01_P001-India-The_Sundarbans
WorldView2 sample image available from Apollo Mapping: http://apollomapping.com/image_downloads/WV2_8band_Bundle_Sydney_Australia.zip
follow-up: 15 comment:14 by , 10 years ago
Looking at:
grass70/imagery/i.atcorr $ grep -nr wv2 * iwave.cpp:2463: /* WV2 Pan of wv2_spectral_response */ iwave.cpp:2505: /* WV2 Coastal Blue of wv2_spectral_response */ iwave.cpp:2547: /* WV2 Blue of wv2_spectral_response */ iwave.cpp:2589: /* WV2 Green of wv2_spectral_response */ iwave.cpp:2631: /* WV2 Yellow of wv2_spectral_response */ iwave.cpp:2673: /* WV2 Red of wv2_spectral_response */ iwave.cpp:2715: /* WV2 RedEdge of wv2_spectral_response */ iwave.cpp:2757: /* WV2 NIR1 of wv2_spectral_response */ iwave.cpp:2799: /* WV2 NIR2 of wv2_spectral_response */
it seems that support has been added. Didn't notice when. Is there any reference? Should this ticket be closed?
comment:15 by , 10 years ago
Replying to nikosa:
it seems that support has been added. Didn't notice when. Is there any reference? Should this ticket be closed?
It got accidentally submitted in this mixed patch: r60610 (releasebranch7: r61314).
This ticket can be closed once the WorldView2 support has been tested. Can you do that?
follow-up: 17 comment:16 by , 10 years ago
The data seem to be wrong. I updated (again), see attached file (next post). A quick test with a blue WorldView?2 band, though, didn't seem to work-out well :-(.
ps- can we remove old attached files?
by , 10 years ago
Attachment: | worldview2_cpp_template.txt added |
---|
updated spectral response data for wv2
follow-up: 18 comment:17 by , 10 years ago
Replying to nikosa:
The data seem to be wrong. I updated (again), see attached file (next post).
Which post?
A quick test with a blue WorldView?2 band, though, didn't seem to work-out well :-(.
ps- can we remove old attached files?
No, AFAIK trac does not support this. The trick is to *substitute* patches (use the same attachment name and click on the "overwrite" checkbox).
comment:18 by , 10 years ago
Replying to neteler:
Replying to nikosa:
The data seem to be wrong. I updated (again), see attached file (next post).
Which post?
File attached in the previous msg: http://trac.osgeo.org/grass/attachment/ticket/2059/worldview2_cpp_template.txt
comment:19 by , 9 years ago
Replying to nikosa:
Attached .csv file, hopefully correctly formatted. The source for the data was: http://www.orfeo-toolbox.org/doxygen/otbWorldView2ImageMetadataInterface_8cxx_source.html, line 918 and beyond.
Just for the record: current file position as of OTB 5.0:
http://hg.orfeo-toolbox.org/OTB/file/6b41126f5257/Modules/Core/Metadata/src/
--> otbWorldView2ImageMetadataInterface.cxx
comment:20 by , 9 years ago
Milestone: | 7.0.0 → 7.0.5 |
---|
comment:21 by , 8 years ago
Milestone: | 7.0.5 → 7.3.0 |
---|
comment:24 by , 8 years ago
Milestone: | 7.4.0 → 7.2.1 |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
I have re-generated the CSV table from a spreadsheet (see r70887) and replaced the Worldview2 sensor functions accordingly using the code generated by create_iwave.py.
Upon successful testing this needs to be backported.
comment:26 by , 8 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Never mind, I accidentially committed in relbr72. Now forward-ported to trunk, too, in r70888.
Testing can now be done both in relbr72 and trunk.
If ok, the ticket can be closed.
comment:27 by , 8 years ago
Milestone: | 7.2.1 → 7.2.2 |
---|
comment:28 by , 8 years ago
Milestone: | 7.2.2 → 7.2.1 |
---|
Is it working ok and the ticket can be closed with 7.2.1 milestone?
comment:30 by , 7 years ago
FYI: The WorldView2 support in i.atcorr received further updates. See #3483, will be released with 7.4.0.
Would you mind to provide the spectral data as a patch for i.atcorr? For instructions, see http://svn.osgeo.org/grass/grass/trunk/imagery/i.atcorr/README