Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#3603 closed defect (fixed)

Trunk does not compile on Mac

Reported by: cmbarton Owned by: grass-dev@…
Priority: critical Milestone:
Component: Default Version: svn-trunk
Keywords: calc, nviz Cc:
CPU: Unspecified Platform: MacOSX

Description

I have not been able to compile GRASS trunk since last week. I did a fresh checkout this morning to try it again with r72966. There are errors in:

/lib/nviz (new this morning) /lib/calc (as was the case last week) /misc/m.nviz.image (does not make because /lib/nviz does not make)

I am attaching the error output for both items. We can split ticket if needed.

Attachments (2)

nviz_error.txt​ (6.9 KB ) - added by cmbarton 6 years ago.
nviz compile error
calc_error.txt​ (1.1 KB ) - added by cmbarton 6 years ago.
calc compile error

Download all attachments as: .zip

Change History (13)

by cmbarton, 6 years ago

Attachment: nviz_error.txt​ added

nviz compile error

by cmbarton, 6 years ago

Attachment: calc_error.txt​ added

calc compile error

comment:1 by cmbarton, 6 years ago

Part probably related to ticket #3600

in reply to:  description ; comment:2 by mmetz, 6 years ago

Replying to cmbarton:

I have not been able to compile GRASS trunk since last week. I did a fresh checkout this morning to try it again with r72966. There are errors in:

/lib/nviz (new this morning) /lib/calc (as was the case last week)

do you have 

extern func_t f_ceil;
extern func_t f_floor;

in

Applications/GRASS-7.5.app/Contents/Resources/include/defs/calc.h

and also in

Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include/grass/defs/calc.h

?

/misc/m.nviz.image (does not make because /lib/nviz does not make)

I am attaching the error output for both items. We can split ticket if needed.

in reply to:  1 ; comment:3 by hcho, 6 years ago

Replying to cmbarton:

Part probably related to ticket #3600

Please make sure to copy the latest include/nviz.h to your dist.../include/grass/nviz.h

New members width and height were added to render_window struct.

in reply to:  2 ; comment:4 by cmbarton, 6 years ago

Replying to mmetz:

Replying to cmbarton:

I have not been able to compile GRASS trunk since last week. I did a fresh checkout this morning to try it again with r72966. There are errors in:

/lib/nviz (new this morning) /lib/calc (as was the case last week)

do you have 

extern func_t f_ceil;
extern func_t f_floor;

in

Applications/GRASS-7.5.app/Contents/Resources/include/defs/calc.h

and also in

Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include/grass/defs/calc.h

?

Yes to both questions

/misc/m.nviz.image (does not make because /lib/nviz does not make)

I am attaching the error output for both items. We can split ticket if needed.

in reply to:  3 comment:5 by cmbarton, 6 years ago

Replying to hcho:

Replying to cmbarton:

Part probably related to ticket #3600

Please make sure to copy the latest include/nviz.h to your dist.../include/grass/nviz.h

New members width and height were added to render_window struct.

Copy from where? I have a fresh trunk checkout.

in reply to:  4 ; comment:6 by mmetz, 6 years ago

Replying to cmbarton:

Replying to mmetz:

Replying to cmbarton:

I have not been able to compile GRASS trunk since last week. I did a fresh checkout this morning to try it again with r72966. There are errors in:

/lib/nviz (new this morning) /lib/calc (as was the case last week)

do you have 

extern func_t f_ceil;
extern func_t f_floor;

in

Applications/GRASS-7.5.app/Contents/Resources/include/defs/calc.h

and also in

Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include/grass/defs/calc.h

?

Yes to both questions

This is not possible. The error message suggests: 

/Applications/GRASS-7.5.app/Contents/Resources/include/grass/defs/calc.h:63:15: note: 'f_float' declared here
	extern func_t f_float;

but f_float is now in line 65, two lines further down, because the two new functions f_ceil and f_floor have been added. That means 

/Applications/GRASS-7.5.app/Contents/Resources/include/grass/defs/calc.h

is not up to date.

Why is 

Applications/GRASS-7.5.app/Contents/Resources/include

included at all? The location of GRASS includes at compile time should be 

Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include

without alternative locations.

in reply to:  6 ; comment:7 by cmbarton, 6 years ago

Replying to mmetz:

Replying to cmbarton:

Replying to mmetz:

Replying to cmbarton:

I have not been able to compile GRASS trunk since last week. I did a fresh checkout this morning to try it again with r72966. There are errors in:

/lib/nviz (new this morning) /lib/calc (as was the case last week)

do you have 

extern func_t f_ceil;
extern func_t f_floor;

in

Applications/GRASS-7.5.app/Contents/Resources/include/defs/calc.h

I do NOT have anything in Applications/GRASS-7.5.app/Contents/Resources/include/defs/ because source won't compile

and also in

Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include/grass/defs/calc.h

I do have it here

?

Yes to both questions

This is not possible. The error message suggests: 

/Applications/GRASS-7.5.app/Contents/Resources/include/grass/defs/calc.h:63:15: note: 'f_float' declared here
	extern func_t f_float;

but f_float is now in line 65, two lines further down, because the two new functions f_ceil and f_floor have been added. That means 

/Applications/GRASS-7.5.app/Contents/Resources/include/grass/defs/calc.h

is not up to date.

Why is 

Applications/GRASS-7.5.app/Contents/Resources/include

included at all? The location of GRASS includes at compile time should be 

Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include

without alternative locations.

in reply to:  7 comment:8 by mmetz, 6 years ago

Replying to cmbarton:

I do NOT have anything in Applications/GRASS-7.5.app/Contents/Resources/include/defs/ because source won't compile

citing from calc_error.txt posted by yourself: 

/Applications/GRASS-7.5.app/Contents/Resources/include/grass/defs/calc.h:63:15: note: 'f_float' declared here

comment:9 by cmbarton, 6 years ago

That's the install path, but I have not been able to do a make install. I will delete the app and try again.

comment:10 by cmbarton, 6 years ago

Resolution: → fixed
Status: new → closed

Figure it out. Somehow make was finding the old version in the install path. Deleting the app made it compile without errors. Thanks.

in reply to:  9 comment:11 by mmetz, 6 years ago

Replying to cmbarton:

That's the install path, but I have not been able to do a make install. I will delete the app and try again.

Why is the install path 

Applications/GRASS-7.5.app/Contents/Resources/include

included at all? The location of GRASS includes at compile time should be 

Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include

without alternative locations.

This path 

Users/cmbarton/grass_source/trunk/dist.x86_64-apple-darwin17.6.0/include

can be outdated, please also double-check 

Users/cmbarton/grass_source/trunk/include
Note: See TracTickets for help on using tickets.