test_r_slope_aspect.py is not idempotent

[pmav99]

test_r_slope_aspect.py is not idempotent, i.e. running the test twice passes the first time but fails the second. The problem is that the maps that are getting created are not removed on cleanUp and as a result, subsequent runs are failing.

The tests can be fixed either by passing --overwrite or by cleaning up the created maps. Unless there are specific reasons preventing us from doing so, I would suggest cleaning up.

PS. My guess is that the tests on fatra are always being run on a fresh copy of the test dataset, that's why this has not been noticed until now.

[sbl]

It seems fatra is using multirunner.py and creates and tears down a mapset per testfile. Still, proper cleanup should be implemented. Patches are welcome...

[pmav99]

After removing the following maps, the tests pass again:

fractal_aspect
fractal_slope
limits_aspect
limits_slope
limits_percent_aspect
limits_percent_slope
reference_aspect
reference_slope
sa_separately_aspect
sa_separately_slope
sa_together_aspect
sa_together_slope
small_aspect
small_elevation
small_slope