Select Within cause a 500 error in the browser

[hubu]

1. Open a basic weblayout in the Firefox 3.5.
2. Select some features (including polygon and multipolygon or line/linestring).
3. The FF encounter a 500 Internal server error.

[chrisclaydon]

Patch review: This solution seems a little restrictive, unless the server-side code is unable to support queries on properly created multi-geometries. And it seems strange that the original code would have been written explicitly to handle MultiPolygon, CurvePolygon and MultiCurvePolygon types if this were not the case.

Would it be possible to check the type on each feature, and create a multipolygon as before if each and every one is a polygon, create a multi-geometry if they are a mix of supported types, and either skip unsupported types such as linestrings, or break out and return null if they are encountered.

[hubu]

Thanks Chris! I have updated the patch according to your comments.

In this patch, I check the type for each feature. And create a multipolygon if there are only polygon. If there are unsupported types, continue and go to the next one. For mixed supported types, create a multi-geometry.

BTW, the MG Server, the render service doesn't support QueryFeatures for the multi-geometry. So If we create a multi-polygoemetry, QueryFeatures will return null, and everything in the map will be cleared.

[chrisclaydon]

The patch now looks ok to me. I'm still a little worried about the lack of support for multi-geometries. If the features include a poly-polygon, does the select within function fail? Curve-polygon and multi-curve polygon seem like they'd be much less common. Do you have any datasets that include them?

I think you can probably submit the patch as-is. But we may need to address related defects, if they come up, in the server code.

[brucedechant]

Fix submitted to trunk - r4452