Opened 12 months ago
Last modified 12 months ago
#3100 assigned task
Heisenbridge identd patch is buggy
Reported by: | lnicola | Owned by: | lnicola |
---|---|---|---|
Priority: | normal | Milestone: | Unplanned |
Component: | SysAdmin/Matrix | Keywords: | |
Cc: |
Description (last modified by )
Jan 07 16:38:17 matrix python[164321]: ERROR:asyncio:Task exception was never retrieved Jan 07 16:38:17 matrix python[164321]: future: <Task finished coro=<Identd.handle() done, defined at /home/heisenbridge/hbridge/lib/python3.7/site-packages/heisenbridge/identd.py:11> exception=TypeError('can only concatenate str (not "IncompleteReadError") to str')> Jan 07 16:38:17 matrix python[164321]: Traceback (most recent call last): Jan 07 16:38:17 matrix python[164321]: File "/home/heisenbridge/hbridge/lib/python3.7/site-packages/heisenbridge/identd.py", line 13, in handle Jan 07 16:38:17 matrix python[164321]: data = await asyncio.wait_for(reader.readuntil(b"\r\n"), 10) Jan 07 16:38:17 matrix python[164321]: File "/usr/lib/python3.7/asyncio/tasks.py", line 416, in wait_for Jan 07 16:38:17 matrix python[164321]: return fut.result() Jan 07 16:38:17 matrix python[164321]: File "/usr/lib/python3.7/asyncio/streams.py", line 585, in readuntil Jan 07 16:38:17 matrix python[164321]: raise IncompleteReadError(chunk, None) Jan 07 16:38:17 matrix python[164321]: asyncio.streams.IncompleteReadError: 0 bytes read on a total of None expected bytes Jan 07 16:38:17 matrix python[164321]: During handling of the above exception, another exception occurred: Jan 07 16:38:17 matrix python[164321]: Traceback (most recent call last): Jan 07 16:38:17 matrix python[164321]: File "/home/heisenbridge/hbridge/lib/python3.7/site-packages/heisenbridge/identd.py", line 64, in handle Jan 07 16:38:17 matrix python[164321]: logging.debug("Identd request threw exception, ignored: " + err) Jan 07 16:38:17 matrix python[164321]: TypeError: can only concatenate str (not "IncompleteReadError") to str
It's not in Ansible, but I think strk patched heisenbridge to log the identd errors. But the patch is incorrect, as it's treating the exception as a string.
Note:
See TracTickets
for help on using tickets.