Opened 13 years ago

Closed 13 years ago

#1020 closed patch (fixed)

bug in BOX2DFLOAT4_in function due to GSERIALIZED_ON change

Reported by: Bborie Park Owned by: pramsey
Priority: medium Milestone: PostGIS 2.0.0
Component: postgis Version: master
Keywords: Cc:

Description

Just a simple bug causing a seg fault in the raster regression test "create_rt_box2d_test".

The bug is how the variables are being passed to sscanf on line 45 of postgis/lwgeom_box2dfloat4.c.

A patch is attached.

Attachments (2)

diff.patch (588 bytes ) - added by Bborie Park 13 years ago.
lwgeom_box2dfloat4.c.patch (596 bytes ) - added by Bborie Park 13 years ago.

Download all attachments as: .zip

Change History (5)

by Bborie Park, 13 years ago

Attachment: diff.patch added

comment:1 by pramsey, 13 years ago

Resolution: fixed
Status: newclosed

Applied. I'm sure there's many more problems in that code area, as it's all #define'd into a new type (GBOX), so Many Things Should Break.

by Bborie Park, 13 years ago

Attachment: lwgeom_box2dfloat4.c.patch added

comment:2 by Bborie Park, 13 years ago

Resolution: fixed
Status: closedreopened

I've attached another patch as the same sscanf call chokes on the format mask which is defined as float while the elements of GBOX are double.

With this change (and yet to be commited patch for raster), the number of raster regressions drops to 2.

comment:3 by pramsey, 13 years ago

Resolution: fixed
Status: reopenedclosed

OK, applied at r7395

Note: See TracTickets for help on using tickets.