shp2pgsql is using deprecated PostgreSQL escape syntax

[robe]

For some datasets I get this

HINT: Use the escape string syntax for backslashes, e.g., E'
'. WARNING: nonstandard use of
in a string literal LINE 1: ...w','St','Brighton','02135','Residential','3','R3','
2003
2...

[pramsey]

Try this micro-patch and see if it goes away...

[robe]

That seems to work. You going to commit?

[robe....@…]

​http://postgis.googlecode.com/issues/attachment?aid=-5423139989644836315&name=esc.patch

[pramsey]

Committed at r3623

[robe]

sample file

[robe]

I think the changes done in #123 r3989 broke this and worst yet, I can no longer import my sample file with either shp2pgsql or the shp2pgsql gui. Gives the annoying escape errors and also that I have invalid characters for SQL ASCII or some such thing. The -W latin1 also doesn't work.

Try attached file.

[mcayland]

Thanks for the report Regina. Since I have standard_conforming_strings enabled on my installation, I missed the fact that I need to explicitly set this in the output file for people that don't. Should now be fixed in r3994 - please test your end and close if it works.

ATB,

Mark.

[robe]

Mark, Well you partly fixed it. I can now import, BUT the gui still gives the warning

HINT: Use the escape string syntax for escapes, e.g., E'\r\n'. WARNING: nonstandard use of escape in a string literal LINE 1: ...,'Av','Roslindale','02131','Residential','3','R3','\2003\200... The shp2pgsql as far as I can tell is perfectly fine now, but I'll test with more shapefile loadings I have lying around.

[mcayland]

Okay, it looks as if I missed part of the conversion, i.e. sprintf()s need to be changed to pgis_exec(). Can you try again now and see if works?

ATB,

Mark.

[robe]

Seems fine now