uninstall script is broken

[robe]

The mix of DROP FUNCTION gives error ERROR: function st_minimumboundingcircle(geometry) does not exist

I think this may be because of some of the functions I took out.

All these calls should be really DROP IF EXISTS. We shouldn't have an DROP FUNCTION. But there appers to be a mix of both.

As well as those hideous drop cascades.

[strk]

Did anyone consider generating the script from postgis.sql ?

[strk]

pg_dump --schema-only --clean # seems to be going in the right direction. Mind you: it does do CASCADE!

[strk]

As of PostgreSQL 8.4.9, pg_dump is bogus, producing these lines:

DROP TYPE public.spheroid CASCADE;
DROP FUNCTION public.spheroid_out(spheroid);
DROP FUNCTION public.spheroid_in(cstring);

which are clearly in the wrong order

[strk]

Beside, the other order would also be broken as you can't drop one w/out dropping the other. Which also means you'll _need_ the CASCADE.

[strk]

r8505 fixes the script manually. Please file another ticket if there are more issues with it. NOTE: no "IF EXISTS" is added, nor any "CASCADE" was dropped.