postgis_upgrade_20_minor.sql is broken

[robe]

Did someone change the perl script to upgrade minor. It's outputing spatial_ref_sys table (well trying to create it), thus it odesn't work. This might be the issue Aren Cambre was running into.

​http://www.postgis.org/pipermail/postgis-users/2011-December/031732.html

Can we please get rid of that. We didn't change the structure of spatial_ref_sys.

[strk]

The structure changed adding:

  check (srid > 0 and srid < 999000)

The check would be safer to add after making sure nothing breaks it. Speaking of which, the new_postgis_upgrade script defines the table using the new definition and would thus fail loading data with SRID values >= 999000

[strk]

The script seems to be fooled by definition of _ST_DumpPoints

[strk]

alrigt,the script detects end of a function looking for a pattern: ^*LANGUGAGE

so fails for all functions where LANGUAGE is not on a line of itself. Pretty lame. It's full of missing upgrades...

[strk]

This is now fixed as r8379