Data loss in postgis_restore.pl when data rows have leading dashes

[darkpanda]

postgis_restore.pl can skip over valid data in COPY statements if a row line begins with leading dashes, i.e. appears to be an SQL comment.

Attached is a patch that checks for COPY commands and for the accompanying "\." line that completes them and avoids stripping comments for the duration.

[strk]

Thanks! r9905 in 2.0 branch, r9906 in trunk

[darkpanda]

I think the same issue exists in older versions of PostGIS as well, so if there were any plans for further 1.5 releases the same style of fix should probably be applied there as well. I haven't had to use postgis_restore.pl on my older 1.5 databases, but I'm assuming the same issue will occur around line 648. I haven't personally confirmed this however, but that's what it looks like in the code.

I can write a quick patch if y'all want, but I believe the few lines that the patch consists of are going to be pretty much identical to the existing patch.

[strk]

I'll happily commit a patch (or pull it from a git branch)

[darkpanda]

Alright, I gave it a shot. See the latest attached patch against the 1.5 branch.

[strk]

r10049 in 1.5 branch -- all done