Build errors for 1.5 with PostgreSQL 9.2.0

[darkpanda]

I was experiencing some build errors with 1.5.5 using PostgreSQL 9.2.0 using clang on OSX. Here's a sampling of the errors I spotted:

lwgeom_estimate.c
lwgeom_estimate.c:318:3: error: use of undeclared identifier 'Form_pg_class'
                Form_pg_class reltup = (Form_pg_class) GETSTRUCT(class_tuple);

The fix was to include utils/rel.h in a few places. A patch is attached.

[robe]

Changes already in 2.0/2.1. We currently don't support 1.5 on 9.2

http://trac.osgeo.org/postgis/wiki/UsersWikiPostgreSQLPostGIS

Is there a reason why you are trying to use 1.5 with 9.2 instead of the newer 2.0/2.1?

[darkpanda]

Ah, didn't notice that.

We're in the middle of upgrading both PostgreSQL to 9.2 and PostGIS to 2.0, so yeah, we're moving to PostGIS 2.0, but we just want to smooth out the transition by doing one and then the other. We also found that pg_upgrade wouldn't let us transfer from our older 9.0 and 9.1 clusters to 9.2 without having all of the various shared modules available in each cluster, so we needed to have both PostGIS 1.5 installed for the conversion process and later 2.0 installed for the PostGIS upgrade.

So no, we don't have a hard reason to not being using 2.0 as that's our plan anyways, but the upgrade path via pg_upgrade isn't an option without having both 1.5 available temporarily alongside 2.0 as far as I can tell.

[robe]

Okay. I guess my general opinion on this is: It would be better to -

1) Upgrade to 2.0 first before upgrading to 9.2

or 2) Just do a dump restore rather than using pg_upgrade for this case you have.

The main reason being, you are going to have to dump restore your database anyway to go from 1.5 to 2.0 since there is no soft upgrade path going from 1.5 to 2.0.

[darkpanda]

Yeah, the only problem in that case is where you have multiple databases in the same cluster and they can't for whatever reason all be transitioned, but I'll worry about that on my end. Cheers.

[robe]

okay pramsey evidentally had a heart and fixed this at #2071

Let's for sake of argument say it's unsupported. I really don't want to support 1.5 for another 5 years ro have people yelling at my door if they find a bug with it in 9.2