Opened 11 years ago
Closed 5 years ago
#2535 closed enhancement (worksforme)
Add safety logic to EXTENSION scripts to avoid misuse
Reported by: | strk | Owned by: | strk |
---|---|---|---|
Priority: | medium | Milestone: | PostGIS Fund Me |
Component: | postgis | Version: | master |
Keywords: | Cc: |
Description
Nobody should be allowed to CREATE FROM UNPACKAGED when target version doesn't match installed version. We should add version checkers in the scripts to do that.
Not sure if this means having versioned "unpackaged" files, but I guess that's the case. Maybe version for "unpackaged" could only include Major.Minor numbers.
Change History (8)
comment:1 by , 11 years ago
comment:2 by , 11 years ago
Milestone: | PostGIS 2.1.2 → PostGIS 2.2.0 |
---|---|
Version: | 2.1.x → trunk |
comment:3 by , 11 years ago
Owner: | changed from | to
---|
I don't think you can do that because then you can't upgrade it.
I think you just have to in the unpackaged script run the check script version and return an error if it fails. Since the package scripts are run in a transaction, I think the script will just bail out.
In theory this should be pretty much a non-issue if done right, because since we add new functions on each minor, the unpackaged script for the current version would fail anyway because it would try to add a function not in current users install and then bail when it can't find it.
comment:4 by , 11 years ago
I should add the check is really more need for micros. People saying they are running 2.1.1 when they are running 2.1.0
comment:6 by , 9 years ago
Milestone: | PostGIS 2.2.0 → PostGIS Future |
---|
comment:8 by , 5 years ago
Resolution: | → worksforme |
---|---|
Status: | new → closed |
This is now deprecated because we now upgrade as part of unpackaged--version
See also http://lists.osgeo.org/pipermail/postgis-devel/2013-October/023805.html