Opened 10 years ago

Closed 13 months ago

#3078 closed enhancement (fixed)

Simplify skip list of postgis_restore.pl wrt comments

Reported by: strk Owned by: strk
Priority: medium Milestone: PostGIS 3.4.1
Component: build Version: 2.1.x
Keywords: postgis_restore Cc:

Description

I don't think COMMENTS necessarely need their own entry in the skip list. Rather, we could skip comments on objects that are in the skip list instead.

Doing so would fix both failing cases reported here: ​http://lists.osgeo.org/pipermail/postgis-users/2015-March/040282.html

With just the update committed in r13334 (after "update-restore" rule in r13333)

Change History (6)

comment:1 by strk, 10 years ago

Status: new → assigned

comment:2 by Algunenano, 5 years ago

Milestone: → PostGIS Fund Me

comment:3 by strk, 13 months ago

Keywords: postgis_restore added

Another case in which skipping comments on skept functions would help is ​https://trac.osgeo.org/postgis/ticket/5569#comment:14

comment:4 by strk, 13 months ago

Milestone: PostGIS Fund Me → PostGIS 3.4.1
Status: assigned → new

Associated pull request: ​https://git.osgeo.org/gitea/postgis/postgis/pulls/160

comment:5 by Sandro Santilli <strk@…>, 13 months ago

In a6d5ce0/git:

Simplify handling of comment signatures

Always skip comments on skipped objects.
Stop including now unneded comment signatures
in the installed postgis_restore script, reducing
its size by 65% (163k)

In master branch (3.5.0dev):

References #3078 #5569

comment:6 by Sandro Santilli <strk@…>, 13 months ago

Resolution: → fixed
Status: new → closed

In bc51b1a6/git:

Simplify handling of comment signatures

Always skip comments on skipped objects.
Stop including now unneded comment signatures
in the installed postgis_restore script, reducing
its size by 65% (163k)

In 3.4 branch (3.4.1dev):

Closes #3078
References #5569

Note: See TracTickets for help on using tickets.