Opened 9 years ago

Closed 9 years ago

#3180 closed defect (fixed)

topology regress failures on windows 9.4 64-bit

Reported by: robe Owned by: strk
Priority: blocker Milestone: PostGIS 2.2.0
Component: topology Version: master
Keywords: Cc: esseffe

Description

Winnie regress failures after r13702 commit

Loading PostGIS into 'postgis_reg' 
  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/postgis.sql
  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/postgis_comments.sql
Loading Topology into 'postgis_reg'
  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/topology.sql
  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/topology_comments.sql
PostgreSQL 9.4.2, compiled by Visual C++ build 1800, 64-bit
  Postgis 2.2.0dev - r13702 - 2015-06-25 18:26:12
  scripts 2.2.0dev r13702
  GEOS: 3.5.0dev-CAPI-1.9.0 r4057
  PROJ: Rel. 4.9.1, 04 March 2015

Running tests

 regress/legacy_validate .. ok 
 regress/legacy_predicate .. ok 
 regress/legacy_invalid .. ok 
 regress/sqlmm .. ok 
 regress/legacy_query .. ok 
 regress/addnode .. failed (diff expected obtained: /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_6_diff)
-----------------------------------------------------------------------------
--- regress/addnode_expected	2014-08-07 22:32:08 -0400
+++ /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_6_out	2015-06-25 14:30:05 -0400
@@ -8,7 +8,8 @@
 p4|4
 p5|5
 post-p5|1|LINESTRING(0 10,5 10)
-post-p5|2|LINESTRING(5 10,10 10)
+post-p5|176739904|LINESTRING(5 10,10 10)
+ERROR:  insert or update on table "edge_data" violates foreign key constraint "next_left_edge_exists"
 p6|6
 p7|7
 1||POINT(0 0)
@@ -17,7 +18,7 @@
 4||POINT(10 10)
 5||POINT(5 10)
 6||POINT(0 20)
-7|1|POINT(5 25)
+7|0|POINT(5 25)
 Topology 'nodes' dropped
 t
 MiX|1
-----------------------------------------------------------------------------
 regress/addedge .. ok 
 regress/addface .. ok 
 regress/addface2.5d .. ok 
 regress/addtopogeometrycolumn .. ok 
 regress/polygonize .. ok 
 regress/st_addisoedge .. ok 
 regress/st_addisonode .. ok 
 regress/st_addedgemodface .. ok 
 regress/st_addedgenewfaces .. ok 
 regress/st_changeedgegeom .. ok 
 regress/st_createtopogeo .. ok 
 regress/st_getfacegeometry .. ok 
 regress/st_getfaceedges .. ok 
 regress/st_modedgeheal .. ok 
 regress/st_modedgesplit .. failed (diff expected obtained: /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_21_diff)
-----------------------------------------------------------------------------
--- regress/st_modedgesplit_expected	2014-08-07 22:32:08 -0400
+++ /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_21_out	2015-06-25 14:30:09 -0400
@@ -15,29 +15,26 @@
 ERROR:  SQL/MM Spatial exception - invalid topology name
 noniso|23
 N|23||POINT(28 14)
-E|10|sn13|en23|nl27|nr17|lf7|rf4
-E|27|sn23|en14|nl-20|nr-10|lf7|rf4
+E|10|sn13|en23|nl171878688|nr17|lf7|rf4
+E|171878688|sn23|en14|nl-20|nr-10|lf7|rf4
 iso|24
 N|24||POINT(11 35)
-E|25|sn21|en24|nl28|nr25|lf1|rf1
-E|28|sn24|en22|nl-28|nr-25|lf1|rf1
+E|25|sn21|en24|nl174044944|nr25|lf1|rf1
+E|174044944|sn24|en22|nl-174044944|nr-25|lf1|rf1
 dangling_end|25
 N|25||POINT(25 32)
-E|3|sn2|en25|nl29|nr2|lf2|rf2
-E|29|sn25|en3|nl-29|nr-3|lf2|rf2
-dangling_start|26
-N|26||POINT(45 32)
-E|4|sn5|en26|nl30|nr4|lf0|rf0
-E|30|sn26|en6|nl-5|nr-4|lf0|rf0
+E|3|sn2|en25|nl173639232|nr2|lf2|rf2
+E|173639232|sn25|en3|nl-173639232|nr-3|lf2|rf2
+ERROR:  duplicate key value violates unique constraint "edge_data_pkey"
 closed|27
 N|27||POINT(3 38)
-E|1|sn1|en27|nl31|nr-31|lf1|rf0
-E|31|sn27|en1|nl1|nr-1|lf1|rf0
+E|1|sn1|en27|nl173672064|nr-173672064|lf1|rf0
+E|173672064|sn27|en1|nl1|nr-1|lf1|rf0
 robust.1|E32|N30
 N|28||POINT(20 10)
 N|29||POINT(10 20)
 N|30||POINT(9 12)
-E|32|sn28|en30|nl33|nr32|lf0|rf0
-E|33|sn30|en29|nl-33|nr-32|lf0|rf0
+E|32|sn28|en30|nl173745936|nr32|lf0|rf0
+E|173745936|sn30|en29|nl-173745936|nr-32|lf0|rf0
 robust.2|t|t
 Topology 'city_data' dropped
-----------------------------------------------------------------------------
 regress/st_newedgeheal .. ok 
 regress/st_newedgessplit .. ok 
 regress/st_remedgenewface .. ok 
 regress/st_remedgemodface .. ok 
 regress/st_simplify .. ok 
 regress/topoelement .. ok 
 regress/topoelementarray_agg .. ok 
 regress/topogeo_addlinestring .. failed (diff expected obtained: /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_29_diff)
-----------------------------------------------------------------------------
--- regress/topogeo_addlinestring_expected	2015-06-25 14:30:01 -0400
+++ /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_29_out	2015-06-25 14:30:11 -0400
@@ -21,159 +21,130 @@
 iso_ex_tol|27
 noniso_ex|18
 noniso_ex_tol|18
-contained|29
+contained|17450912
 N|27||POINT(35 8)
 N|28||POINT(35 12)
 E|18|sn10|en27
-E|29|sn27|en28
-E|30|sn28|en13
-overlap|31
-overlap|32
-N|29||POINT(49 22)
-N|30||POINT(45 22)
-E|8|sn18|en30
-E|31|sn19|en29
-E|32|sn30|en19
+E|17450912|sn27|en28
+E|178051456|sn28|en13
+ERROR:  duplicate key value violates unique constraint "edge_data_pkey"
 cross|34
 cross|35
 N|31||POINT(49 18)
 N|32||POINT(47 17.6)
 N|33||POINT(44 17)
 E|15|sn12|en32
-E|33|sn32|en19
 E|34|sn31|en32
 E|35|sn32|en33
-snap|36
-snap|39
-snap|40
-N|34||POINT(18 22)
-N|35||POINT(22.4 22)
-N|36||POINT(21 20.4)
-E|6|sn16|en34
-E|7|sn17|en35
-E|19|sn14|en36
-E|36|sn34|en17
-E|37|sn35|en18
-E|38|sn36|en17
-E|39|sn35|en36
-E|40|sn17|en35
-snap_again|36
-snap_again|39
-snap_again|40
-crossover|43
-crossover|45
-crossover|46
-crossover|47
-N|37||POINT(9 20)
-N|38||POINT(16.2 14)
-N|39||POINT(21 10)
-N|40||POINT(9 18)
-N|41||POINT(21 7)
-E|9|sn15|en38
-E|20|sn9|en41
-E|21|sn15|en40
-E|41|sn37|en16
-E|42|sn38|en14
-E|43|sn37|en38
-E|44|sn39|en14
-E|45|sn38|en39
-E|46|sn40|en37
-E|47|sn41|en39
-crossover_again|43
-crossover_again|45
-crossover_again|46
-crossover_again|47
+E|178076080|sn32|en19
+ERROR:  duplicate key value violates unique constraint "edge_data_pkey"
+snap_again|41
+snap_again|42
+snap_again|181880768
+N|36||POINT(18 22)
+N|37||POINT(22.4 22)
+N|38||POINT(21 20.4)
+E|6|sn16|en36
+E|7|sn17|en37
+E|19|sn14|en38
+E|41|sn37|en38
+E|42|sn17|en37
+E|181856144|sn38|en17
+E|181880768|sn36|en17
+E|181921808|sn37|en18
+ERROR:  duplicate key value violates unique constraint "edge_data_pkey"
+ERROR:  duplicate key value violates unique constraint "edge_data_pkey"
 contains|25
-contains|48
-contains|49
-N|42||POINT(7 36)
-N|43||POINT(14 34)
-E|48|sn21|en42
-E|49|sn43|en22
-nodecross|50
-nodecross|51
-N|44||POINT(18 37)
-N|45||POINT(22 37)
-E|50|sn44|en4
-E|51|sn4|en45
+contains|45
+contains|46
+N|41||POINT(7 36)
+N|42||POINT(14 34)
+E|45|sn21|en41
+E|46|sn42|en22
+nodecross|47
+nodecross|48
+N|43||POINT(18 37)
+N|44||POINT(22 37)
+E|47|sn43|en4
+E|48|sn4|en44
 iso_ex_2segs|28
-#1613.1|52
-N|46||POINT(556267.6 144887)
-N|47||POINT(556267 144887.4)
-E|52|sn46|en47
-#1613.2|54
-#1613.2|55
-N|48||POINT(556250 144887)
-N|49||POINT(556267.6 144887)
-N|50||POINT(556310 144887)
-E|52|sn46|en49
-E|53|sn49|en47
-E|54|sn48|en49
-E|55|sn49|en50
-#1631.1|56
-N|51||POINT(556267.6 144887)
-N|52||POINT(556267.6 144888)
-E|56|sn51|en52
-#1631.2|57
-#1631.2|58
-N|53||POINT(556254.6 144886.6)
-N|54||POINT(556267.6 144887)
-E|57|sn53|en51
-E|58|sn51|en54
-#1641.1|59
-N|55||POINT(-0.2 0.4)
-N|56||POINT(0.2 0.4)
-E|59|sn55|en56
-#1641.2|61
-#1641.2|62
-N|57||POINT(0 0.2)
+#1613.1|49
+N|45||POINT(556267.6 144887)
+N|46||POINT(556267 144887.4)
+E|49|sn45|en46
+#1613.2|51
+#1613.2|52
+N|47||POINT(556250 144887)
+N|48||POINT(556267.6 144887)
+N|49||POINT(556310 144887)
+E|49|sn45|en48
+E|51|sn47|en48
+E|52|sn48|en49
+E|181864352|sn48|en46
+#1631.1|53
+N|50||POINT(556267.6 144887)
+N|51||POINT(556267.6 144888)
+E|53|sn50|en51
+#1631.2|54
+#1631.2|55
+N|52||POINT(556254.6 144886.6)
+N|53||POINT(556267.6 144887)
+E|54|sn52|en50
+E|55|sn50|en53
+#1641.1|56
+N|54||POINT(-0.2 0.4)
+N|55||POINT(0.2 0.4)
+E|56|sn54|en55
+#1641.2|58
+#1641.2|59
+N|56||POINT(0 0.2)
+N|57||POINT(0 0.4)
 N|58||POINT(0 0.4)
-N|59||POINT(0 0.4)
-E|59|sn55|en58
-E|60|sn58|en56
-E|61|sn57|en58
-E|62|sn58|en59
-#1641.3|63
-N|60||POINT(-0.2 0.4)
-N|61||POINT(0.2 0.4)
-E|63|sn60|en61
-#1641.4|65
-#1641.4|66
-N|62||POINT(0 0.2)
+E|56|sn54|en57
+E|58|sn56|en57
+E|59|sn57|en58
+E|17500160|sn57|en55
+#1641.3|60
+N|59||POINT(-0.2 0.4)
+N|60||POINT(0.2 0.4)
+E|60|sn59|en60
+#1641.4|62
+#1641.4|63
+N|61||POINT(0 0.2)
+N|62||POINT(0 0.4)
 N|63||POINT(0 0.4)
-N|64||POINT(0 0.4)
-E|63|sn60|en63
-E|64|sn63|en61
-E|65|sn62|en63
-E|66|sn63|en64
+E|60|sn59|en62
+E|62|sn61|en62
+E|63|sn62|en63
+E|181954640|sn62|en60
 #1650.1
-N|65|0|POINT(0 0)
-#1650.3|67
-N|66||POINT(10 0)
-E|67|sn65|en66
-#1654.1|N|67
-N|67|0|POINT(0 0)
-#1654.2|68
-#1654.2|69
-N|68||POINT(-10 1)
-N|69||POINT(10 1)
-E|68|sn68|en67
-E|69|sn67|en69
-#1706.1|E|70
-N|70||POINT(20 10)
-N|71||POINT(10 20)
-E|70|sn70|en71
-#1706.2|E*|70
-#1706.2|E*|72
-#1706.2|E*|73
-N|72||POINT(10 0)
-N|73||POINT(10 10)
-N|74||POINT(15 10)
-E|70|sn70|en74
-E|71|sn73|en71
-E|72|sn72|en73
-E|73|sn74|en73
-#1714.1|N|75
-N|75|0|POINT(10 0)
-#1714.2|E*|74
+N|64|0|POINT(0 0)
+#1650.3|64
+N|65||POINT(10 0)
+E|64|sn64|en65
+#1654.1|N|66
+N|66|0|POINT(0 0)
+#1654.2|65
+#1654.2|66
+N|67||POINT(-10 1)
+N|68||POINT(10 1)
+E|65|sn67|en66
+E|66|sn66|en68
+#1706.1|E|67
+N|69||POINT(20 10)
+N|70||POINT(10 20)
+E|67|sn69|en70
+#1706.2|E*|67
+#1706.2|E*|69
+#1706.2|E*|177977584
+N|71||POINT(10 0)
+N|72||POINT(10 10)
+N|73||POINT(15 10)
+E|67|sn69|en73
+E|69|sn71|en72
+E|177977584|sn73|en72
+E|181954640|sn72|en70
+#1714.1|N|74
+N|74|0|POINT(10 0)
+#1714.2|E*|71
 Topology 'city_data' dropped
-----------------------------------------------------------------------------
 regress/topogeo_addpoint .. failed (diff expected obtained: /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_30_diff)
-----------------------------------------------------------------------------
--- regress/topogeo_addpoint_expected	2014-08-07 22:32:08 -0400
+++ /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_30_out	2015-06-25 14:30:11 -0400
@@ -18,7 +18,7 @@
 N|24|3|POINT(16 18)
 N|25||POINT(26 30)
 E|2|2|25
-E|27|25|2
+E|16647936|25|2
 prec1|N23
 prec2|N26
 prec3|N27
-----------------------------------------------------------------------------
 regress/topogeo_addpolygon .. failed (diff expected obtained: /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_31_diff)
-----------------------------------------------------------------------------
--- regress/topogeo_addpolygon_expected	2014-08-07 22:32:08 -0400
+++ /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_31_out	2015-06-25 14:30:12 -0400
@@ -31,9 +31,9 @@
 split|13
 N|26||POINT(28 18)
 E|30|sn14|en26
-E|31|sn26|en18
 E|32|sn26|en13
 E|33|sn17|en26
+E|173655648|sn26|en18
 F|14
 F|15
 ex_hole|3
-----------------------------------------------------------------------------
 regress/topogeometry_type .. ok 
 regress/topojson .. failed (diff expected obtained: /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_33_diff)
-----------------------------------------------------------------------------
--- regress/topojson_expected	2014-08-07 22:32:08 -0400
+++ /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_33_out	2015-06-25 14:30:12 -0400
@@ -48,5 +48,5 @@
 E33
 E34
 E35
-A3-vanilla|P6|{ "type": "MultiPolygon", "arcs": [[[-33],[30,25],[1]],[[-34],[34]]]}
+A3-vanilla|P6|{ "type": "MultiPolygon", "arcs": [[[-33],[182183775,25],[1]],[[-34],[34]]]}
 Topology 'city_data' dropped
-----------------------------------------------------------------------------
 regress/topologysummary .. ok 
 regress/topo2.5d .. ok 
 regress/totopogeom .. failed (diff expected obtained: /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_36_diff)
-----------------------------------------------------------------------------
--- regress/totopogeom_expected	2014-08-07 22:32:08 -0400
+++ /projects/postgis/tmp/2.2.0dev_pg9.4_geos3.5.0dev_gdal2.0.0w64/test_36_out	2015-06-25 14:30:13 -0400
@@ -32,7 +32,7 @@
 MULTIPOLYGON EMPTY
 MULTIPOLYGON EMPTY
 GEOMETRYCOLLECTION EMPTY
-tolerance_1|0.5
+ERROR:  duplicate key value violates unique constraint "edge_data_pkey"
 tolerance_topo_1|0.5
 tolerance_0|0
 custom_search_path|0
-----------------------------------------------------------------------------
 regress/droptopology .. ok 
 regress/droptopogeometrycolumn .. ok 
 regress/copytopology .. ok 
 regress/createtopogeom .. ok 
 regress/createtopology .. ok 
 regress/gml .. ok 
 regress/getnodebypoint .. ok 
 regress/getedgebypoint .. ok 
 regress/getfacebypoint .. ok 
 regress/getringedges .. ok 
 regress/gettopogeomelements .. ok 
 regress/layertrigger .. ok 
 regress/validatetopology .. ok 
 uninstall .  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/uninstall_topology.sql
  /projects/postgis/branches/2.2/regress/00-regress-install/share/contrib/postgis/uninstall_postgis.sql
. ok (4336)

Run tests: 50
Failed: 7

Change History (5)

comment:1 by robe, 9 years ago

Priority: mediumblocker

comment:2 by strk, 9 years ago

Status: newassigned

Ouch, 176739904 rather than 1 ! Could be an int64 vs. int32 (interpretation) issue. I'm on it.

comment:3 by strk, 9 years ago

Cc: esseffe added

Adding Sandro in Cc as he's going to look at using the new liblwgeom-topo API from spatialite anyway

comment:4 by strk, 9 years ago

Please check with r13715. The code was fetching a 64bit integer using DatumGetInt32... (on 64bit linux with PostgreSQL and PostGIS compiled using GCC everything worked nonetheless).

comment:5 by robe, 9 years ago

Resolution: fixed
Status: assignedclosed

okay I think that fixed it. Just did a test of the 64-bit w/o sfcgal. I'll do a full run on all variations after I've rebuilt newer sfcgal and reopen if it's still an issue.

Note: See TracTickets for help on using tickets.