PostGIS 2.0 CUnit too new on Debbie - Segfaults

[robe]

Looks like the last change broke PostGIS 2.0. Debbie stopped at PostgreSQL 9.0 (which is the first), so it might only be 9.0 that is broken since she stopped there.

-------------- Dependencies -------------- 
  GEOS config:          /var/lib/jenkins/workspace/geos/rel-3.5.1devw64/bin/geos-config
  GEOS version:         3.5.1
  GDAL config:          /var/lib/jenkins/workspace/gdal/rel-1.11w64/bin/gdal-config
  GDAL version:         1.11.4
  PostgreSQL config:    /var/lib/jenkins/workspace/pg/rel/pg9.0w64/bin/pg_config
  PostgreSQL version:   PostgreSQL 9.0.23
  PROJ4 version:        49
  Libxml2 config:       /usr/bin/xml2-config
  Libxml2 version:      2.9.3
  JSON-C support:       yes
  PostGIS debug level:  0
  Perl:                 /usr/bin/perl

 --------------- Extensions --------------- 
  PostGIS Raster:       enabled
  PostGIS Topology:     enabled

 -------- Documentation Generation -------- 
  xsltproc:             /usr/bin/xsltproc
  xsl style sheets:     /usr/share/xml/docbook/stylesheet/nwalsh
  dblatex:              /usr/bin/dblatex
  convert:              /usr/bin/convert
  mathml2.dtd:          http://www.w3.org/Math/DTD/mathml2/mathml2.dtd

Error log is as follows: ​http://debbie.postgis.net:8080/job/PostGIS_Regress/2993/console

                                                                                       ^
cu_in_wkt.c:370:87: note: (near initialization for ‘wkt_in_suite.pSetUpFunc’)
gcc -g -O2  -Wall -Wmissing-prototypes -I/var/lib/jenkins/workspace/geos/rel-3.5.1devw64/include   -I.. -c -o cu_tester.o cu_tester.c
/bin/bash ../../libtool --mode=link gcc -g -O2  -Wall -Wmissing-prototypes -I/var/lib/jenkins/workspace/geos/rel-3.5.1devw64/include   -o cu_tester cu_algorithm.o cu_buildarea.o cu_clean.o cu_print.o cu_misc.o cu_ptarray.o cu_geodetic.o cu_geos.o cu_measures.o cu_node.o cu_libgeom.o cu_split.o cu_stringbuffer.o cu_homogenize.o cu_out_wkt.o cu_out_wkb.o cu_out_gml.o cu_out_kml.o cu_out_geojson.o cu_out_svg.o cu_surface.o cu_out_x3d.o cu_in_wkb.o cu_in_wkt.o cu_tester.o  ../liblwgeom.la -lcunit
libtool: link: gcc -g -O2 -Wall -Wmissing-prototypes -I/var/lib/jenkins/workspace/geos/rel-3.5.1devw64/include -o .libs/cu_tester cu_algorithm.o cu_buildarea.o cu_clean.o cu_print.o cu_misc.o cu_ptarray.o cu_geodetic.o cu_geos.o cu_measures.o cu_node.o cu_libgeom.o cu_split.o cu_stringbuffer.o cu_homogenize.o cu_out_wkt.o cu_out_wkb.o cu_out_gml.o cu_out_kml.o cu_out_geojson.o cu_out_svg.o cu_surface.o cu_out_x3d.o cu_in_wkb.o cu_in_wkt.o cu_tester.o  ../.libs/liblwgeom.so -lcunit
#gcc -o cu_tester cu_algorithm.o cu_buildarea.o cu_clean.o cu_print.o cu_misc.o cu_ptarray.o cu_geodetic.o cu_geos.o cu_measures.o cu_node.o cu_libgeom.o cu_split.o cu_stringbuffer.o cu_homogenize.o cu_out_wkt.o cu_out_wkb.o cu_out_gml.o cu_out_kml.o cu_out_geojson.o cu_out_svg.o cu_surface.o cu_out_x3d.o cu_in_wkb.o cu_in_wkt.o cu_tester.o  ../.libs/liblwgeom.a -lm -lcunit -L/var/lib/jenkins/workspace/geos/rel-3.5.1devw64/lib -lgeos_c
Makefile:62: recipe for target 'check' failed
make[2]: *** [check] Segmentation fault
make[2]: Leaving directory '/var/lib/jenkins/workspace/postgis/branches/2.0/liblwgeom/cunit'
Makefile:147: recipe for target 'check' failed
make[1]: *** [check] Error 2
make[1]: Leaving directory '/var/lib/jenkins/workspace/postgis/branches/2.0/liblwgeom'
GNUmakefile:14: recipe for target 'check' failed
make: *** [check] Error 1

Commit that triggered this appears to be:

r14607

[pramsey]

My installation segfaults in exactly the same place, but it has been doing so for quite some time, for a known reason: 2.0 is not compatible with the latest versions of CUNIT. So if you've updated cunit on your test infra, that would account for the segfault. Updating to recent count compatibility is somewhat laborious, so I only did it for 2.1 and 2.2 (which was trunk at the time)

[robe]

Hmm so maybe it was last time I ran apt update then that caused it. I wonder if I can do like I do on windows and not use system, and compile a lower CUnit. Which CUnit version doesn't have this issue?

I'd just dismiss it, but I'm sure strk would not be happy that no bot is testing 2.0.

[pramsey]

Not honestly sure. 2.1-2? ​http://sourceforge.net/projects/cunit/files/CUnit/2.1-2/

[robe]

On second thought I was mistaken. Both git-lab and travis are testing 9.0 and passing, so I'll just turn off testing on debbie for 2.0, so she can focus on more important things. Will still keep the source tar ball generation.