Opened 8 years ago

Closed 8 years ago

#3630 closed defect (fixed)

Both debbie and winnie are failing on sfcgal tickets

Reported by: robe Owned by: pramsey
Priority: blocker Milestone: PostGIS 2.3.0
Component: postgis Version: master
Keywords: Cc:

Description

 sfcgal/tickets .. failed (diff expected obtained: /projects/postgis/tmp/2.3.0rc1dev_pg9.6_geos3.5.0_gdal2.1.1w64/test_123_diff)
-----------------------------------------------------------------------------
--- sfcgal/tickets_expected	2016-09-12 12:02:22 -0400
+++ /projects/postgis/tmp/2.3.0rc1dev_pg9.6_geos3.5.0_gdal2.1.1w64/test_123_out	2016-09-12 12:05:53 -0400
@@ -197,7 +197,7 @@
 #852.2|1|t|t
 #852.2|2|t|t
 #1489|MULTIPOINT EMPTY|0|MULTILINESTRING EMPTY|0|MULTIPOLYGON EMPTY|0|GEOMETRYCOLLECTION EMPTY|0
-ERROR:  AddToPROJ4SRSCache: could not parse proj4 string ''
+ERROR:  AddToPROJ4SRSCache: could not parse proj4 string '' 
 #1038|
 #1042|2
 #1170|90
@@ -208,7 +208,7 @@
 #1580.1|Point[S]
 ERROR:  transform: couldn't project point (180 90 0): tolerance condition error (-20)
 #1580.3|Point[S]
-#1596.1|public.road_pg.roads_geom SRID:3395 TYPE:POINT DIMS:2
+#1596.1|public.road_pg.roads_geom SRID:3395 TYPE:POINT DIMS:2 
 ERROR:  invalid SRID: 330000 not found in spatial_ref_sys
 #1596.3|3395
 ERROR:  invalid SRID: 999000 not found in spatial_ref_sys
-----------------------------------------------------------------------------

Since commit r15098

Looks like just a linefeed issue probably. What's odd is my commit should have broken things and strk's fixed, but seems to be other way around. Mine didn't trigger a failure but his did.

Change History (3)

comment:1 by strk, 8 years ago

Editorconfig must have removed trailing spaces that should have been instead expected, comping from:

    elog(ERROR,                                                                 
        "AddToPROJ4SRSCache: could not parse proj4 string '%s' %s",             
        proj_str, pj_errstr);  

Looks like pj_errstr would be empty when given an proj_str...

comment:2 by robe, 8 years ago

yah I'm fixing now.

comment:3 by strk, 8 years ago

Resolution: fixed
Status: newclosed

In 15101:

Re-add accidentally removed trailing spaces in an _expected file

Also tweak .editorconfig to avoid this accident in the future

Fixes #3630

Note: See TracTickets for help on using tickets.