Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3632 closed defect (fixed)

getFaceByPoint test relies on invalid topology

Reported by: strk Owned by: strk
Priority: medium Milestone: PostGIS 2.3.0
Component: topology Version: 2.2.x
Keywords: Cc: aperi2007

Description

Trying a faster Point-In-Polygon test I found that topology/test/regress/getfacebypoint.sql is expecting a debating result for the test 't5'.

The argument point falls within an "inner" face but the "inner" face isn't correctly registered but rather marked as being part of the universe face. This is an invalid topology, constructed via AddEdge/AddFace calls within the test itself.

I suggest the topology is corrected and both a test for point-in-hole and point-in-universe replace the existing 't5' test.

Andrea: adding you in Cc as I believe you were the author of that test

Change History (3)

comment:1 by strk, 8 years ago

Cc: aperi2007 added; aperi removed

comment:2 by strk, 8 years ago

Resolution: fixed
Status: newclosed

In 15129:

Fix test for getFaceByPoint to not rely on invalid topology

Closes #3632

comment:3 by robe, 8 years ago

Milestone: PostGIS FuturePostGIS 2.3.0
Note: See TracTickets for help on using tickets.