Opened 8 years ago

Closed 8 years ago

#3635 closed defect (duplicate)

utils/create_spatial_ref_sys_config_dump.pl has hardcoded perl path

Reported by: gdt Owned by: strk
Priority: medium Milestone: PostGIS 2.3.0
Component: build Version: master
Keywords: Cc:

Description

This script starts with "#!/usr/bin/perl", but some systems (e.g. NetBSD/pkgsrc) do not include perl in the base system, placing it elsewhere (e.g. /usr/pkg/bin/perl).

Arguably the 100% correct solution is to substitute the perl path found by configure, but that's hard. Instead, use env to find perl

Attachments (1)

utils-perl.patch (348 bytes ) - added by gdt 8 years ago.
patch to use /usr/bin/env to find perl

Download all attachments as: .zip

Change History (3)

by gdt, 8 years ago

Attachment: utils-perl.patch added

patch to use /usr/bin/env to find perl

comment:1 by strk, 8 years ago

Note that postgis_upgrade.pl is generated at ./configure time from postgis_upgrade.pl.in, if you're looking for an example

comment:2 by robe, 8 years ago

Resolution: duplicate
Status: newclosed

gdt,

I thought this line is ignored if perl is called explicitly. I think this is why I had the issue in #3639 which I fixed by explicitly calling the PERL we are using in r15135.

That said, I'm going to reject this patch and mark this ticket as a duplicate of #3639 for 2 reasons

1) Have no idea it's effect on other systems, and too scared to apply so close to release time 2) If we change this perl script, I would have to argue why aren't we changing the header of all the .pl scripts in utils folder which all have - #!/usr/bin/perl

So if we revisit this, I think we should have a patch that changes all the perl scripts.

Note: See TracTickets for help on using tickets.