lwin_wkt_parse, lwin_wkt_lex.c keep on regenerating

[robe]

I'm not sure what the issue is here, but as of late every time I compile code lwin_wkt_parse.c, lwin_wkt_lex.c, lwin_wkt_parse.h

keep on regenerating

I'm running Bison 3.0.4

I guess it's possible I upgraded my Bison in the past couple of months. Anyone else experiencing this. It's particularly annoying cause I have to remember to not commit thouse.

[strk]

it should be only dependent on make. Please show the output of this:

cd liblwgeom
make lwin_wkt_parse.c
make lwin_wkt_parse.c
ls -l lwin_wkt_parse.c lwin_wkt_parse.y

If lwin_wkt_parse.y has timestamp in the future you'd keep building what's considered older by the operating system...

[robe]

Hmm it's saying it's up to date now. I guess I'll just have to check next time I compile.

last two lines:

ls -l lwin_wkt_parse.c lwin_wkt_parse.y
-rw-r--r-- 1 Administrator None 108002 Aug 27 21:49 lwin_wkt_parse.c
-rw-r--r-- 1 Administrator None  20988 Aug 27 10:58 lwin_wkt_parse.y

It might not be every time I compile. Perhaps its only at certain times. Just tried recompiling and it didn't autogenerate. I'll monitor this more closely. For recent patches I've had to make changes to files in liblwgeom / lwgeodetic.c, lwgeodetic.h

could that be triggering something?

[strk]

you can check by touching each of those files and running make:

touch liblwgeom/lwgeodetic.h && make

[pramsey]

A small change in liblwgeom/lwin_wkt_parse.y is now causing this again more frequently. I'd regenerate the files and check them in, but I have an old version of bison on my machines.

[strk]

How about removing them from repository ? Is it really that hard to install bison and flex nowadays ?

[pramsey]

Different versions generate different output, have different feature sets. Some platforms it *is* harder to get them. Just generating a new set and committing them fixes us for another 5 years until someone adds a change to the parser again.

[pramsey]

In #4017, I committed changes to the lexer and updated the dates on the generated files to be after the source files, so hopefully this will stop for a while.