--enable-debug to set PARANOIA level

[pramsey]

Repurpose the --enable-debug flag to turn on PARANOIA and add as much -g debugging as possible (in particular to liblwgeom, since ./postgis inherits its flags from the pgsql build in pg_config --cflags)

[pramsey]

Done at r15662, with quite a few more changes than expected, mostly in cleaning up the protobuf autoconf. Hopefully this doesn't regress any other platforms, will watch the CI bots.

[robe]

note sure if related to this but dronie seems not happy. Was happy commit before

​https://drone.osgeo.org/postgis/postgis/274

#3837, --enable-debug to set PARANOIA level This required some re-working of the protobuf sections, for reasons that aren't clear. However, hopefully that re-working will also fix things for others. Basically, the pkg-config portions seemed to only work by accident for the folks who wrote them initially, so they are improved, and the use of --without is more strongly enforced in the conditional blocks git-svn-id: http://svn.osgeo.org/postgis/trunk@15662 b70326c6-7e19-0410-871a-916f4a2858ee 

  Test: test_lw_arc_center ...passed
  Test: test_point_density ...passed
  Test: test_kmeans ...passed
  Test: test_median_handles_3d_correctly ...passed
  Test: test_median_robustness ...make[2]: Leaving directory `/drone/src/git.osgeo.org/gogs/postgis/postgis/liblwgeom/cunit'
make[2]: *** [check] Segmentation fault (core dumped)
make[1]: Leaving directory `/drone/src/git.osgeo.org/gogs/postgis/postgis/liblwgeom'
make[1]: *** [check] Error 2
make: *** [check] Error 1

[robe]

reopening debbie has also voiced her disapproval.

https://debbie.postgis.net/job/PostGIS_Regress/6497/consoleFull

 -------------- Compiler Info ------------- 
  C compiler:           gcc -g -O2
  SQL preprocessor:     /usr/bin/cpp -traditional-cpp -w -P

 -------------- Dependencies -------------- 
  GEOS config:          /var/lib/jenkins/workspace/geos/rel-3.7.0devw64/bin/geos-config
  GEOS version:         3.7.0dev
  GDAL config:          /var/lib/jenkins/workspace/gdal/rel-2.2w64/bin/gdal-config
  GDAL version:         2.2.1
  SFCGAL config:        /usr/bin/sfcgal-config
  SFCGAL version:       1.3.0
  PostgreSQL config:    /var/lib/jenkins/workspace/pg/rel/pg9.6w64/bin/pg_config
  PostgreSQL version:   PostgreSQL 9.6.5
  PROJ4 version:        49
  Libxml2 config:       /usr/bin/xml2-config
  Libxml2 version:      2.9.4
  JSON-C support:       yes
  protobuf-c support:   yes
  PCRE support:         yes
  PostGIS debug level:  
  Perl:                 /usr/bin/perl

Suite: computational_geometry
  Test: test_lw_segment_side ...passed
  Test: test_lw_segment_intersects ...passed
  Test: test_lwline_crossing_short_lines ...passed
  Test: test_lwline_crossing_long_lines ...passed
  Test: test_lwline_crossing_bugs ...passed
  Test: test_lwpoint_set_ordinate ...passed
  Test: test_lwpoint_get_ordinate ...passed
  Test: test_point_interpolate ...passed
  Test: test_lwline_clip ...passed
  Test: test_lwline_clip_big ...passed
  Test: test_lwmline_clip ...passed
  Test: test_geohash_point ...passed
  Test: test_geohash_precision ...passed
  Test: test_geohash ...passed
  Test: test_geohash_point_as_int ...passed
  Test: test_isclosed ...passed
  Test: test_lwgeom_simplify ...passed
  Test: test_lw_arc_center ...passed
  Test: test_point_density ...passed
  Test: test_kmeans ...passed
  Test: test_median_handles_3d_correctly ...passed
  Test: test_median_robustness ...Makefile:86: recipe for target 'check' failed
make[2]: *** [check] Segmentation fault
make[2]: Leaving directory '/var/lib/jenkins/workspace/postgis/branches/2.4/liblwgeom/cunit'
Makefile:205: recipe for target 'check' failed
make[1]: *** [check] Error 2
make[1]: Leaving directory '/var/lib/jenkins/workspace/postgis/branches/2.4/liblwgeom'
GNUmakefile:16: recipe for target 'check' failed
make: *** [check] Error 1
Build step 'Execute shell' marked build as failure
An attempt to send an e-mail to empty list of recipients, ignored.
Warning: you have no plugins providing access control for builds, so falling back to legacy behavior of permitting any downstream builds to be triggered
Triggering a new build of PostgreSQL stop
Finished: FAILURE

[robe]

yap all bots are angry. All complaining about the same thing core dump in test_median_robustness

[robe]

okay closing this out now. Only failing bot now since 15671 is winnie which is only failing on 10. I think that's my fault though with something I missed in building pg10 on her.