Unused variables in recent raster code

[robe]

dustymugs,

Assume these are result of your recent changes. Welcome back :)

Dronie and Gitlab Ci have adopted the same anal retentive mindset as their father. Soo you must now not have unused variables lying around, lest you get cursed by them and eventually their father may notice and come after you.

rt_raster.c: In function 'rt_raster_gdal_drivers':
rt_raster.c:1721:14: error: unused variable 'is_raster' [-Werror=unused-variable]
  const char *is_raster;
              ^
cc1: all warnings being treated as errors
make[2]: Leaving directory `/drone/src/git.osgeo.org/gogs/postgis/postgis/raster/rt_core'
make[1]: Leaving directory `/drone/src/git.osgeo.org/gogs/postgis/postgis/raster'
make[2]: *** [rt_raster.o] Error 1
make[1]: *** [corelib] Error 2
make: *** [all] Error 1

[Bborie Park]

By chance, is Dronie and Gitlab CI using GDAL < 2.0? I'm guessing yes as that variable is only used in a block of code activated for GDAL >= 2.0

[Bborie Park]

Fixed as of r16199

[robe]

I would suspect so. They are running ancient GEOS and proj as well. That would also explain why travis didn't pick it up, cause I think travis checks for unused variables as well.

[komzpa]

Do we have a list of configuration variants for each lib that are different from one another?

Like "gdal < 2.0", "gdal >= 2.0", "proj < 4.9", "proj >= 4.9", "json-c < 12", "json-c >= 13".

If we do we can set a build matrix for all of them, or at least most common, to catch these.