#4046 closed defect (fixed)
Revise Debbie Web Hook jobs (fix doc build)
Reported by: | robe | Owned by: | robe |
---|---|---|---|
Priority: | blocker | Milestone: | Website Management, Bots |
Component: | QA/buildbots | Version: | master |
Keywords: | Cc: |
Description (last modified by )
They changed the Generic Web Hook plugin to standardize on lowercase key names
https://github.com/jenkinsci/generic-webhook-trigger-plugin/blob/master/CHANGELOG.md
1.30 (2018-03-08 17:59:01) No issue improve header variable name description Version 1.28 introduced RFC 2616 compatibility making all headers lowercase. This patch adds a note to make this fact more obvious. Example situation where this matters: a CI systems that checks for X-GitHub-Event header to make further decisions. Since 1.28 the resulting variable changes from X_GitHub_Event to x_github_event effectively breaking this process. 0fd81969349a1d0 jekader 2018-03-08 17:28:09 1.29 (2018-03-06 20:26:35) GitHub #45 "This project is parameterized" parameters are being ignored if triggered bug Keeping default values in parameterized jobs #45 602ea1fd613abd2 Tomas Bjerre 2018-03-06 20:25:41
I think the 1.28 change is what broke the doc building (as Dan Baston noticed) and the 1.30 will break the others, so have to change all of those that use regex to match by lower case.
Change History (5)
comment:1 by , 7 years ago
Description: | modified (diff) |
---|
comment:2 by , 7 years ago
Description: | modified (diff) |
---|
comment:3 by , 7 years ago
comment:4 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
I fixed the postgis worker runs (the debbies). I also fixed the PostGIS_Make_Dist that does the building of docs and tar ball.
the trunk job I still have on svn hook so it was still working. Will have to change that to web hook too at some point.
I'll close this ticket after I've upgraded winnie's jenkins and fixed all her webhook jobs.