Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#4231 closed defect (fixed)

PostGIS can't build with PostgreSQL v12devel because "pg_constraint.consrc" has been removed

Reported by: Laurenz Albe Owned by: robe
Priority: blocker Milestone: PostGIS 2.5.2
Component: postgis Version: 2.5.x -- EOL
Keywords: Cc:

Description

PostgreSQL v12 has removed the pg_constraint.consrc column in commit 96b00c43.

The recommendation is to use pg_get_constraintdef instead.

Now PostGIS relies pretty heavily on this column, so it won't work with PostgreSQL v12 any more.

I can try and come up with a fix, but it is not a 5 minute affair, and I will habe little time in the near future, so I thought I'd better alert you.

Change History (11)

comment:1 by robe, 6 years ago

Owner: changed from pramsey to robe
Priority: mediumblocker

Laurenz thanks for the ticket and commit that broke it.

I'll work on a patch for this. It did hit a lot of pieces in our code base.

Much appreciated.

comment:2 by robe, 6 years ago

It looks like we might be able to backport it as this was something we should have stopped using a while ago evidentally.

comment:3 by robe, 6 years ago

Milestone: PostGIS 3.0.0PostGIS 2.5.2
Version: trunk2.5.x

comment:4 by robe, 6 years ago

In 17030:

Put back deprecated functions removed in r17029, but patch them to use newer pg_get_constraintdef function.
Also mark them as undeprecated cause they are used in other management functions, and it's too messy to change those to use teh raw sql.
We maybe stuck with these forever :(
Closes #4243 for PostGIS 3.0

Also fix error in raster patching
References #4231 for PostGIS 3.0

comment:5 by robe, 6 years ago

In 17031:

Revert accidental commit
References #4231 for PostGIS 3.0

comment:6 by robe, 6 years ago

In 17032:

One more error in raster change - hopefully this is it
References #4231 for PostGIS 3.0

comment:7 by robe, 6 years ago

In 17049:

Replace pg_constraint.consrc for pg_get_constraintdef fix for topology
References #4231 for PostGIS 3.0.0

comment:8 by Laurenz Albe, 6 years ago

It builds fine for me now, thanks for the effort!

comment:9 by Laurenz Albe, 6 years ago

Resolution: fixed
Status: newclosed

comment:10 by robe, 6 years ago

In 17060:

Add 2.2.8 to upgrade targets
Remove using of pg_constraint.consrc to allow support of 12 as noted by Laurenz Albe (pg_constraint.consrc was removed in 12devel)
Closes #4231 for postgis 2.5.2

comment:11 by robe, 6 years ago

In 17061:

Missed a spot in last commit
Closes #4231 for postgis 2.5.2

Note: See TracTickets for help on using tickets.