Opened 6 years ago
Closed 6 years ago
#4244 closed enhancement (fixed)
Travis: Enable UBSan checks in CI
Reported by: | Algunenano | Owned by: | Algunenano |
---|---|---|---|
Priority: | medium | Milestone: | PostGIS 3.0.0 |
Component: | postgis | Version: | master |
Keywords: | Cc: |
Description
Change History (9)
comment:1 by , 6 years ago
comment:3 by , 6 years ago
PR adding clang UBsan checks: https://github.com/postgis/postgis/pull/337
Thanks to Kompzpa for the help adding Clang to the docker image.
Pending:
- Have a Docker image that compiles Postgresql with clang so clang's ubsan is also run in the extension code (the part using PGXS). This would also be useful in case we want to debug JIT issues, as currently gcc is being used.
- Fix topology undefined behaviour alerts: I might revisit it at some point in the future, but I find other warnings (memory sanitizer) more interesting right now.
comment:5 by , 6 years ago
The issue in topology is an unaligned memory access in BOX2D_out, so it was really in the Postgis extension, not topology itself.
Addressed in https://github.com/postgis/postgis/pull/342
Note:
See TracTickets
for help on using tickets.
Adding a check with both gcc and clang undefined behaviour sanitizer in Travis.
For now, I'll leave out topology since debugging it requires knowing at least how it's supposed to work.