Opened 6 years ago

Closed 6 years ago

#4251 closed defect (fixed)

topology failing on PostgreSQL 12devel because oids removed

Reported by: robe Owned by: robe
Priority: blocker Milestone: PostGIS 2.5.2
Component: topology Version: 2.4.x
Keywords: Cc:

Description

 regress/legacy_predicate .. failed (diff expected obtained: /var/lib/jenkins/workspace/postgis/tmp/3_0_pg12w64/test_2_diff)
-----------------------------------------------------------------------------
--- regress/legacy_predicate_expected	2018-09-16 16:55:15.018504025 +0000
+++ /var/lib/jenkins/workspace/postgis/tmp/3_0_pg12w64/test_2_out	2018-11-22 07:43:13.490101967 +0000
@@ -5,116 +5,75 @@
 26
 COMMIT
 BEGIN
-1
-2
-3
+ERROR:  syntax error at or near "oids" at character 80
+ERROR:  syntax error at or near "oids" at character 80
+ERROR:  syntax error at or near "oids" at character 81
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
 COMMIT
-4
-features.big_parcels.the_geom SRID:0 TYPE:MULTIPOLYGON DIMS:2 
-5
-6
-features.big_signs.the_geom SRID:0 TYPE:MULTIPOINT DIMS:2 
+ERROR:  relation "features.land_parcels" does not exist at character 13
+ERROR:  relation "features.land_parcels" does not exist at character 13
+ERROR:  relation "features.land_parcels" does not exist at character 13
+ERROR:  relation "features.land_parcels" does not exist at character 13
+ERROR:  relation "features.traffic_signs" does not exist at character 13
+ERROR:  relation "features.traffic_signs" does not exist at character 13
+ERROR:  relation "features.traffic_signs" does not exist at character 13
+ERROR:  relation "features.traffic_signs" does not exist at character 13
+ERROR:  relation "features.city_streets" does not exist at character 13
+ERROR:  relation "features.city_streets" does not exist at character 13
+ERROR:  relation "features.city_streets" does not exist at character 13
+ERROR:  relation "features.city_streets" does not exist at character 13
+ERROR:  syntax error at or near "OIDS" at character 78
+ERROR:  schema "features" does not exist
+ERROR:  Schema 'features' is not a valid schemaname
+ERROR:  relation "features.big_parcels" does not exist at character 13
+ERROR:  relation "features.big_parcels" does not exist at character 13
+ERROR:  relation "features.big_parcels" does not exist at character 13
+ERROR:  syntax error at or near "OIDS" at character 78
+ERROR:  schema "features" does not exist
+ERROR:  relation "features.big_streets" does not exist at character 13
+ERROR:  relation "features.big_streets" does not exist at character 13
+ERROR:  syntax error at or near "OIDS" at character 76
+ERROR:  schema "features" does not exist
+ERROR:  Schema 'features' is not a valid schemaname
+ERROR:  relation "features.big_signs" does not exist at character 13
 BEGIN

topology is still failing for 12 for topoology even after adding the pg_constraint fix

Change History (5)

comment:1 by robe, 6 years ago

I wonder if this is a new change or something amiss with debbie. It's passing fine on my pg12 from head a week ago

comment:2 by robe, 6 years ago

2.5 is even more of a mess for topology for 12 on my machine and I got more failures. I just pulled the latest git master of postgresql

PostgreSQL 12devel on x86_64-w64-mingw32, compiled by gcc.exe (x86_64-posix-seh-                                                                                                                  rev0, Built by MinGW-W64 project) 8.1.0, 64-bit
  Postgis 2.5.2dev - r17061 - 2018-11-23 08:10:04
  scripts 2.5.2dev r17061
  raster scripts 2.5.2dev r17061
  GEOS: 3.7.0-CAPI-1.11.0 673b9939
  PROJ: Rel. 5.2.0, September 15th, 2018
  GDAL: GDAL 2.3.1, released 2018/06/22

Running tests

 regress/legacy_validate .. ok
 regress/legacy_predicate .. failed (diff expected obtained: /projects/postgis/t                                                                                                                  mp/2.5_pg12w64/test_2_diff)
 regress/legacy_invalid .. ok
 regress/sqlmm .. ok
 regress/legacy_query .. failed (diff expected obtained: /projects/postgis/tmp/2                                                                                                                  .5_pg12w64/test_5_diff)
 regress/addnode .. ok
 regress/addedge .. ok
 regress/addface .. ok
 regress/addface2.5d .. ok
 regress/addtopogeometrycolumn .. ok
 regress/polygonize .. ok
 regress/st_addisoedge .. ok
 regress/st_addisonode .. ok
 regress/st_addedgemodface .. ok
 regress/st_addedgenewfaces .. ok
 regress/st_changeedgegeom .. ok
 regress/st_createtopogeo .. ok
 regress/st_getfacegeometry .. ok
 regress/st_getfaceedges .. ok
 regress/st_modedgeheal .. ok
 regress/st_modedgesplit .. ok
 regress/st_newedgeheal .. ok
 regress/st_newedgessplit .. ok
 regress/st_remedgenewface .. failed (diff expected obtained: /projects/postgis/                                                                                                                  tmp/2.5_pg12w64/test_24_diff)
 regress/st_remedgemodface .. failed (diff expected obtained: /projects/postgis/                                                                                                                  tmp/2.5_pg12w64/test_25_diff)
 regress/st_simplify .. ok
 regress/topoelement .. ok
 regress/topoelementarray_agg .. ok
 regress/topogeo_addlinestring .. ok
 regress/topogeo_addpoint .. ok
 regress/topogeo_addpolygon .. ok
 regress/topogeom_edit .. ok
 regress/topogeometry_type .. failed (diff expected obtained: /projects/postgis/                                                                                                                  tmp/2.5_pg12w64/test_33_diff)
 regress/topojson .. failed (diff expected obtained: /projects/postgis/tmp/2.5_p                                                                                                                  g12w64/test_34_diff)
 regress/topologysummary .. ok
 regress/topo2.5d .. ok
 regress/totopogeom .. ok
 regress/droptopology .. ok
 regress/droptopogeometrycolumn .. ok
 regress/copytopology .. failed (diff expected obtained: /projects/postgis/tmp/2                                                                                                                  .5_pg12w64/test_40_diff)
 regress/createtopogeom .. ok
 regress/createtopology .. ok
 regress/gml .. failed (diff expected obtained: /projects/postgis/tmp/2.5_pg12w6                                                                                                                  4/test_43_diff)
 regress/getnodebypoint .. ok
 regress/getedgebypoint .. ok
 regress/getfacebypoint .. ok
 regress/getringedges .. ok
 regress/gettopogeomelements .. failed (diff expected obtained: /projects/postgi                                                                                                                  s/tmp/2.5_pg12w64/test_48_diff)
 regress/layertrigger .. ok
 regress/validatetopology .. ok
 uninstall .. ok (4643)

Run tests: 51
Failed: 9

Or perhaps I glossed over tehm in debbie, cause the first couple diffs I look at have the same oids error.

As I recall I think I saw a headling saying "oids no more", so perhaps they removed oid columns from pg12

comment:3 by robe, 6 years ago

Summary: topology failing on PostgreSQL 12develtopology failing on PostgreSQL 12devel because oids removed

comment:4 by robe, 6 years ago

In 17062:

Get rid of use of oids in topology regress was taken out in PostgreSQL 12.
References #4251 for PostGIS 3.0

comment:5 by robe, 6 years ago

Resolution: fixed
Status: assignedclosed

In 17063:

Get rid of use of oids in topology regress was taken out in PostgreSQL 12.
Closes #4251 for PostGIS 2.5.2

Note: See TracTickets for help on using tickets.