PostgreSQL commits a9c35cf85ca and fa2cf164aaf break build

[Laurenz Albe]

Commit ​fa2cf164aaf91e074be653c28e035f65d80eb666 renamed nodes/relation.h to nodes/pathnodes.h.

This affects postgis/gserialized_estimate.c and is easily fixed by the attached patch.

Commit ​a9c35cf85ca1ff72f16f0f10d7ddee6e582b62b8 is a more difficult affair.

It removed FunctionCallInfoData and replaced it with a variable-length array that is allocated with the LOCAL_FCINFO macro. The way to access the function arguments has also changed.

My attached patch is an attempt to fix all places (which are unfortunately many). This certainly makes the code harder to read.

There are some files where my changes are pretty invasive, mostly raster/rt_pg/rtpg_mapalgebra.c. This would require an extra pair of eyes and some testing.

Of course it would be nice to reduce the number of sites in the code where direct function calls are made.

[Laurenz Albe]

An attempt to fix the build

[Algunenano]

I've created ​https://github.com/postgis/postgis/pull/368 with the patch to pass it through the CI.

The patch seems straightforward except for the raster part. I'll have a look to make sure I don't see anything wrong but I won't enter in detail to reduce the direct usage of function calls there (mainly because I don't know anything about raster).

[Raul Marin]

In 17223:

PostgreSQL 12 compatibility

Initial patch by Laurenz Albe
References #4313

[Raul Marin]

In 17224:

PostgreSQL 12 compatibility

Initial patch by Laurenz Albe
References #4313

[Raul Marin]

In 17225:

PostgreSQL 12 compatibility

Initial patch by Laurenz Albe
Closes #4313
Closes ​https://github.com/postgis/postgis/pull/368/