Opened 5 years ago
Closed 5 years ago
#4620 closed enhancement (fixed)
Review and update wagyu to 0.5.0
| Reported by: | Algunenano | Owned by: | Algunenano |
|---|---|---|---|
| Priority: | medium | Milestone: | PostGIS 3.1.0 |
| Component: | postgis | Version: | master |
| Keywords: | Cc: |
Description
Wagyu 0.5.0 has been released https://github.com/mapbox/wagyu/releases/tag/0.5.0
The plan is to review the differences (should be only the improvements in floating point comparison), performance and update our bundled code.
Attachments (3)
Change History (7)
by , 5 years ago
| Attachment: | before.png added |
|---|
comment:1 by , 5 years ago
0.5.0 Changelog:
Fixed various issues associated with floating point data and comparisions of numbers. This in effect solves some weird intersection bugs and situations where the bounds are not properly sorted. This can result in a variety of different crashes and bad results in the final output in very rare situations.
There are some minor visual differences (example in the attached geometries).
I'm testing how it behaves in terms of performance.
comment:2 by , 5 years ago
Wagyu 0.5.0 seems slightly faster in some cases (up to 1.10x as fast).
It seems too big of a change to attribute it to the variance in the base machine (my development PC, with multithreading, dynamic frequency scaling and so on). I'm more inclined to attribute it to the removal of std::fabs calls in the floating point comparisons.
Wagyu 0.4.3