Error upgrading postGIS from 2.4.4 to 2.5.4 on postgres 10.12

[sjezewskisf]

Hi there -

It seems like there is a regression of this bug:

​https://trac.osgeo.org/postgis/ticket/3683?cversion=0&cnum_hist=1

I work at Heroku where we offer postgres as a service for millions of databases. We offer postGIS support as a beta feature.

Some customers are experiencing problems upgrading from postgres 10.12 with postGIS 2.4.4

The specific error we see is:

`

sql_error_code = 00000 LOG: statement: ALTER EXTENSION "postgis" UPDATE;

sql_error_code = 01000 CONTEXT: SQL statement "SELECT postgis_lib_version()"

PL/pgSQL function postgis_major_version_check() line 21 at SQL statement

sql_error_code = 42883 ERROR: operator does not exist: gidx public.&& geography at character 11 sql_error_code = 42883 HINT: No operator matches the given name and argument type(s). You might need to add explicit type casts. sql_error_code = 42883 QUERY: SELECT $2 OPERATOR(public.&&) $1;

`

The version of postGIS that its attempting to upgrade to is 2.5.4

We have many customers using postGIS 2.4.4 and they will be unable to upgrade (their PG versions) until this is fixed.

It seems like we see postGIS upgrading errors from time to time like this. Do you all have a test matrix that provides clarity on which versions / upgrade paths are supported?

[Algunenano]

Do you have a repro?

[robe]

This should be called the bug that keeps on giving.

Looks like we have a couple of tickets of this all closed #3683 which you mentioned and #3633 and #4257

By chance are the databases you are having trouble with been pg_upgraded from a Pre-PostgreSQL 9.4 edition? It seems a bit odd you'd be running into this otherwise.

[sjezewskisf]

I don't believe that is the case @robe

In this case, their original provisioned version was PG 10.12

[robe]

I'm not able to replicate this issue. I tested upgrading a PostgreSQL 10.5 from PostGIS 2.4.7 to 2.5.5dev and did not run into any issues. Given that 2.4.4 is many micros behind I suppose some fixes have happened since then or a fix is already in place in 2.5.5 unreleased.

So I'm marking this as worksforme.