Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4728 closed defect (fixed)

Remove UPDATE for pgis_abs from upgrade script

Reported by: khannaekta Owned by: pramsey
Priority: medium Milestone: PostGIS 2.5.5
Component: postgis Version: 2.5.x -- EOL
Keywords: Cc:

Description

PostGIS 2.5 onwards pgis_abs type was removed from aggregate/collect routines, but if we look at the upgrade script for versions >=2.5, they still contain an UPDATE for pgis_abs type in the catalog table (https://git.osgeo.org/gitea/postgis/postgis/src/branch/master/postgis/postgis_after_upgrade.sql#L233-L235). Is there a reason we have it else it should be part of versions >=2.5.

Change History (5)

comment:1 by strk, 4 years ago

No reason. Indeed the type is DROP in the same file, earlier. It was removed as per #4035 in 2.5.0. I'll drop that UPDATE. Good catch! (how did you find out ?)

comment:2 by Sandro Santilli <strk@…>, 4 years ago

In cf49794/git:

There's no point in updating pgis_abs type after removing it...

References #4728 in master branch

comment:3 by Sandro Santilli <strk@…>, 4 years ago

In 15a360e/git:

There's no point in updating pgis_abs type after removing it...

References #4728 in 3.0 branch

comment:4 by Sandro Santilli <strk@…>, 4 years ago

Resolution: fixed
Status: newclosed

In 2fe99bbc/git:

There's no point in updating pgis_abs type after removing it...

Closes #4728 in 2.5 branch

in reply to:  1 comment:5 by khannaekta, 4 years ago

Replying to strk:

No reason. Indeed the type is DROP in the same file, earlier. It was removed as per #4035 in 2.5.0. I'll drop that UPDATE. Good catch! (how did you find out ?)

Thanks for the quick fix. I bumped int this when trying to upgrade from 2.1.5 -> 2.5.4 using ALTER EXTENSION postgis UPDATE to '2.5.4'; and it failed with the following error: ERROR: permission denied: "pg_type" is a system catalog.

Note: See TracTickets for help on using tickets.