Opened 4 years ago
Closed 4 years ago
#4762 closed defect (fixed)
debbie makedist is failing
Reported by: | robe | Owned by: | strk |
---|---|---|---|
Priority: | blocker | Milestone: | PostGIS 3.1.0 |
Component: | build | Version: | master |
Keywords: | Cc: |
Description
I'm guessing this might have something to do with MVT changes, but debbie's Make Dist for 3.1 is failing.
5:58:37 generator.c:116:2: error: too many arguments to function ‘lwprint_double’ 05:58:37 116 | lwprint_double(p.y + styles->pointSize, 10, y2, OUT_DOUBLE_BUFFER_SIZE); 05:58:37 | ^~~~~~~~~~~~~~ 05:58:37 In file included from generator.c:37: 05:58:37 ../../../liblwgeom/liblwgeom_internal.h:454:5: note: declared here 05:58:37 454 | int lwprint_double(double d, int maxdd, char *buf); 05:58:37 | ^~~~~~~~~~~~~~ 05:58:37 generator.c: In function ‘main’: 05:58:37 generator.c:356:2: warning: ‘strncat’ specified bound 3 equals source length [-Wstringop-overflow=] 05:58:37 356 | strncat( filename, "png", 3 ); 05:58:37 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 05:58:37 make[2]: *** [Makefile:180: generator.o] Error 1
though it's a bit puzzling to me how mvt would affect generate.c.
https://debbie.postgis.net/job/PostGIS_Make_Dist/label=debbie/2121/consoleFull
Regular build is okay but regular build doesn't try to do imagemagick generation of images.
Change History (2)
comment:1 by , 4 years ago
comment:2 by , 4 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
yap that seems to have fixed it.
Note:
See TracTickets
for help on using tickets.
I think it should be fixed by d575a6e738ef567b05d80096f41c383e264bd8dc
It would be great to add whatever this is doing to the CI, so things break on PRs / commits.