debbie pg13 failing on unpackaged

[robe]

Did we somehow reenable this for pg13 or is it a configuration issue.

Just noticed Debbie's PG13 trunk runs are failing ​https://debbie.postgis.net/job/PostGIS_Regress/15304/consoleFull

22:56:39 ERROR:  CREATE EXTENSION ... FROM is no longer supported
22:56:39 LINE 1: CREATE EXTENSION postgis VERSION '3.1.0dev' FROM unpackaged;
22:56:39                                                     ^
22:56:39 -----------------------------------------------------------------------------
22:56:39 make: *** [Makefile:184: check] Error 1
22:56:39 make: Leaving directory '/var/lib/jenkins/workspace/postgis/branches/3.1/raster/test/regress'
22:56:39 FAIL: upgrade unpackaged3.1--3.1.0dev
22:56:39 Build step 'Execute shell' marked build as failure
22:56:39 Triggering a new build of PostgreSQL stop
22:56:39 Finished: FAILURE

[strk]

The run_test.pl script should now only use CREATE..FROM when the target PostgreSQL version is < 13

Since [520af0e8d1bb6e9544d974713bb87e428ff4230b/git]

[robe]

LOoks like it broke after this commit

Commit 520af0e8d1bb6e9544d974713bb87e428ff4230b by strk

Work around PG13 drop of `FROM unpackaged` syntax

- Always install empty extension--unpackage.sql scripts
- Have run_test.pl use create/update trick for PG13
- Re-enable check_all_upgrades.sh testing of unpackaged
- Have postgis_extensions_upgrade use the unpackaged trick

Fixes #4643

so guess did not work.

[Sandro Santilli <strk@…>]

In e7c3c7f2/git:

Drop duplicated and mis-scoped variable, fixing PG13 unpackaged test

Fixes #4643 for real
Closes #4773