Opened 4 years ago

Closed 4 years ago

Last modified 2 years ago

#4777 closed defect (fixed)

core tests are using \copy with hard-coded relative paths

Reported by: strk Owned by: strk
Priority: medium Milestone: PostGIS 3.1.0
Component: build Version: 2.5.x -- EOL
Keywords: Cc:

Description

This prevents running them from arbitrary directories. These are: core/concave_hull_hard.sql core/regress_big_polygon.sql core/regress_gist_index_nd.sql core/regress_spgist_index_2d.sql core/regress_spgist_index_3d.sql core/regress_spgist_index_nd.sql

Change History (6)

comment:1 by strk, 4 years ago

This blocks #4207

comment:2 by strk, 4 years ago

One solution would be to have run_test.pl perform keyword substitution on the .sql files (psql variables do not work with \copy)

comment:3 by robe, 4 years ago

Component: postgisbuild/upgrade/install
Owner: changed from pramsey to strk

comment:4 by Sandro Santilli <strk@…>, 4 years ago

Resolution: fixed
Status: newclosed

In 47e75c4/git:

Load each regress test in its own directory

Closes #4777 by making it allowed to use hard-coded paths

Update topology tests so hard-coded paths are relative to the
script file rather than the supposed calling path, allowing
them to be run from any directory too

comment:5 by Sandro Santilli <strk@…>, 2 years ago

In 3c7e31f/git:

Use relative paths in topology tests

References #4777 in 3.0 branch (3.0.7dev)

Should fix regression test broken by upgrading of
run_test.pl in commit a0c29068d

comment:6 by Sandro Santilli <strk@…>, 2 years ago

In 4a78ce4/git:

Use relative paths in topology tests

References #4777 in 2.5 branch (2.5.8dev)

Should fix regression test broken by upgrading of
run_test.pl in commit 35b17931f

Note: See TracTickets for help on using tickets.