Proj master branch (8.0.0) regress failures

[Taro Matsuzawa]

I'm working on ​docker-postgis multistage build.

I find current proj master (7.2.0) will fail regress test.

root@299eff78c5c7:/tmp/pgis_reg# cat test_103_diff
--- tickets_expected	2020-11-04 05:44:04.975681093 +0000
+++ /tmp/pgis_reg/test_103_out	2020-11-04 05:46:40.753850135 +0000
@@ -195,7 +195,7 @@
 #1543|MULTILINESTRING((0 0,10 0,10 10,0 0),(0 0))|POLYGON((0 0,10 10,10 0,0 0))
 #1578|f|f
 #1580.1|Point[S]
-ERROR:  transform: tolerance condition error (-20)
+#1580.2|0101000020430D000093107C45F81B7341B97937FF14E8AC41
 #1580.3|Point[S]
 #1596.1|public.road_pg.roads_geom SRID:3395 TYPE:POINT DIMS:2
 ERROR:  invalid SRID: 330000 not found in spatial_ref_sys

The patch only pass test.

diff --git a/regress/core/tickets.sql b/regress/core/tickets.sql
index abb39264f..3df953b11 100644
--- a/regress/core/tickets.sql
+++ b/regress/core/tickets.sql
@@ -591,7 +591,6 @@ select '#1578', st_within(p, mp), st_intersects(p, mp) FROM inp;
 
 -- #1580
 select '#1580.1', ST_Summary(ST_Transform('SRID=4326;POINT(0 0)'::geometry, 3395));
-select '#1580.2', ST_Transform('SRID=4326;POINT(180 90)'::geometry, 3395); -- fails
 select '#1580.3', ST_Summary(ST_Transform('SRID=4326;POINT(0 0)'::geometry, 3395));
 
 -- #1596 --
diff --git a/regress/core/tickets_expected b/regress/core/tickets_expected
index d0cc88a3e..701510256 100644
--- a/regress/core/tickets_expected
+++ b/regress/core/tickets_expected
@@ -195,7 +195,6 @@ ERROR:  got NULL for SRID (500001)
 #1543|MULTILINESTRING((0 0,10 0,10 10,0 0),(0 0))|POLYGON((0 0,10 10,10 0,0 0))
 #1578|f|f
 #1580.1|Point[S]
-ERROR:  transform: tolerance condition error (-20)
 #1580.3|Point[S]
 #1596.1|public.road_pg.roads_geom SRID:3395 TYPE:POINT DIMS:2 
 ERROR:  invalid SRID: 330000 not found in spatial_ref_sys

[Algunenano]

I've just built PROJ 7.2 branch (with proj-data-1.3) and I can't reproduce the behaviour change:

Version:

# Select postgis_full_version();
                                                                                                                             
                                                           postgis_full_version                                              
                                                                                                                             
             
-----------------------------------------------------------------------------------------------------------------------------
-----------------------------------------------------------------------------------------------------------------------------
-----------------------------------------------------------------------------------------------------------------------------
-------------
 POSTGIS="3.1.0dev 968b3478f" [EXTENSION] PGSQL="120" GEOS="3.9.0dev-CAPI-1.14.0" PROJ="7.2.0" GDAL="GDAL 3.0.4, released 202
0/01/28" LIBXML="2.9.10" LIBJSON="0.15" LIBPROTOBUF="1.3.3" WAGYU="0.5.0 (Internal)" (core procs from "3.1.0dev 740dab0bc" ne
ed upgrade) TOPOLOGY (topology procs from "3.1.0dev a313c9e22" need upgrade) RASTER (raster procs from "3.1.0dev 740dab0bc" n
eed upgrade)
(1 row)

Query:

# select '#1580.2', ST_Transform('SRID=4326;POINT(180 90)'::geometry, 3395);
ERROR:  transform: tolerance condition error (-20)

Rebuilding with master/HEAD (8.0.0) does show the new behaviour:

 POSTGIS="3.1.0dev 968b3478f" [EXTENSION] PGSQL="120" GEOS="3.9.0dev-CAPI-1.14.0" PROJ="8.0.0" GDAL="GDAL 3.0.4, released 202
0/01/28" LIBXML="2.9.10" LIBJSON="0.15" LIBPROTOBUF="1.3.3" WAGYU="0.5.0 (Internal)" (core procs from "3.1.0dev 740dab0bc" ne
ed upgrade) TOPOLOGY (topology procs from "3.1.0dev a313c9e22" need upgrade) RASTER (raster procs from "3.1.0dev 740dab0bc" n
eed upgrade)
(1 row)

# select '#1580.2', ST_Transform('SRID=4326;POINT(180 90)'::geometry, 3395);
 ?column? |                    st_transform                    
----------+----------------------------------------------------
 #1580.2  | 0101000020430D000093107C45F81B7341B97937FF14E8AC41

Before doing any change, since 8.0 is unreleased (and 7.2 was released a few days ago), we should confirm with upstream whether this is intended or not.

[Algunenano]

Reported in ​https://github.com/OSGeo/PROJ/issues/2413 to ask whether this new output is valid or not

[Taro Matsuzawa]

Thank you Algunenano to report it.

But I change 3395 from to 32631, I get an error.

root@01f6586c5245:/usr/src/postgis# grep 1580 regress/core/tickets.sql
-- #1580
select '#1580.1', ST_Summary(ST_Transform('SRID=4326;POINT(0 0)'::geometry, 32631));
select '#1580.2', ST_Transform('SRID=4326;POINT(180 90)'::geometry, 32631); -- fails
select '#1580.3', ST_Summary(ST_Transform('SRID=4326;POINT(0 0)'::geometry, 32631));
root@01f6586c5245:/usr/src/postgis# cd /tmp/pgis_reg/
root@01f6586c5245:/tmp/pgis_reg# cat test_72_diff
--- ./core/tickets_expected	2020-11-06 12:10:18.680571000 +0000
+++ /tmp/pgis_reg/test_72_out	2020-11-06 12:12:43.976063000 +0000
@@ -195,7 +195,7 @@
 #1543|MULTILINESTRING((0 0,10 0,10 10,0 0),(0 0))|POLYGON((0 0,10 10,10 0,0 0))
 #1578|f|f
 #1580.1|Point[S]
-ERROR:  transform: tolerance condition error (-20)
+#1580.2|0101000020777F00000000000080841E415F3A2D9ED1116341
 #1580.3|Point[S]
 #1596.1|public.road_pg.roads_geom SRID:3395 TYPE:POINT DIMS:2
 ERROR:  invalid SRID: 330000 not found in spatial_ref_sys

[Algunenano]

Since this is testing that ST_Transform works after a previous failure, I'm planning on triggering a different proj error. Just need to check that the error is consistent across PROJ releases.

[Raúl Marín <git@…>]

In 5b2e3cb/git:

Adapt regress tests for PROJ 8

Closes #4785