Opened 4 years ago

Closed 4 years ago

#4875 closed defect (fixed)

geosmakevalid failure on 3.0 with GEOS 3.9.2dev

Reported by: robe Owned by: robe
Priority: blocker Milestone: PostGIS 3.0.4
Component: postgis Version: 3.0.x
Keywords: Cc:

Description

Seeing this on winnie who is testing 3.9.2dev/PostGIS 3.0 

  Test: test_geos_makevalid ...[cu_geos.c:155]
 Expected: POLYGON((92127.546 463452.075,92117.173 463439.755,92133.675 463425.942,92122.136 463412.826,92092.377 463437.77,92114.014 463463.469,92115.512 463462.207,92115.5120743 463462.206937,92127.546 463452.075))
 Obtained: POLYGON((92115.512 463462.207,92115.5120743 463462.206937,92127.546 463452.075,92117.173 463439.755,92133.675 463425.942,92122.136 463412.826,92092.377 463437.77,92114.014 463463.469,92115.512 463462.207))
FAILED
    1. cu_geos.c:155  - CU_ASSERT_STRING_EQUAL(out_ewkt,"POLYGON((92127.546 463452.075,92117.173 463439.755,92133.675 463425.942,92122.136 463412.826,92092.377 463437.77,92114.014 463463.469,92115.512 463462.207,92115.5120743 463462.206937,92127.546 463452.075))")

I think just got to backport some of the changes from #4837 to 3.0.

Change History (3)

comment:1 by Regina Obe <lr@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In d7d8dfb/git:

cunit makevalid make work for 3.9.2dev and 3.10 as well. Closes #4875 References #4837

comment:2 by robe, 4 years ago

Resolution: fixed
Status: closed → reopened

This still is failing on debbie ​https://debbie.postgis.net/job/PostGIS_Regress/16556/console which makes me concerned that 3.8dev changed as well as the other bots seem fine and the loop she is failing in I did not change. She's running 3.8.2dev 

09:50:17  Expected: GEOMETRYCOLLECTION(POLYGON((92114.014 463463.469,92115.5120743 463462.206937,92115.512 463462.207,92127.546 463452.075,92117.173 463439.755,92133.675 463425.942,92122.136 463412.826,92092.377 463437.77,92114.014 463463.469)),MULTIPOINT(92115.5120743 463462.206937,92122.136 463412.826))
09:50:17  Obtained: GEOMETRYCOLLECTION(POLYGON((92092.377 463437.77,92114.014 463463.469,92115.5120743 463462.206937,92115.512 463462.207,92127.546 463452.075,92117.173 463439.755,92133.675 463425.942,92122.136 463412.826,92092.377 463437.77)),MULTIPOINT(92122.136 463412.826,92115.5120743 463462.206937))
09:50:17 FAILED
09:50:17     1. cu_geos.c:154  - CU_ASSERT_STRING_EQUAL(out_ewkt,"GEOMETRYCOLLECTION(POLYGON((92114.014 463463.469,92115.5120743 463462.206937,92115.512 463462.207,92127.546 463452.075,92117.173 463439.755,92133.675 463425.942,92122.136 463412.826,92092.377 463437.77,92114.014 463463.469)),MULTIPOINT(92115.5120743 463462.206937,92122.136 463412.826))")

comment:3 by Regina Obe <lr@…>, 4 years ago

Resolution: → fixed
Status: reopened → closed

In 39672a19/git:

Need to normalize the output of < 39 route as well. Closes #4875

Note: See TracTickets for help on using tickets.