#4937 closed defect (fixed)
No diffs shown in commit email anymore
Reported by: | strk | Owned by: | robe |
---|---|---|---|
Priority: | medium | Milestone: | |
Component: | management | Version: | |
Keywords: | Cc: |
Description
Since the introduction of symbolic refs (master == main).
I think the culprit is in the show_new_revisions
function of the
/osgeo/git/hookscripts/post-receive-email
script, which tries to find which revisions are not accessible in other refs (while not skipping the symbolic refs)
It's in this snippet:
other_branches=$(git for-each-ref --format='%(refname)' refs/heads/ | grep -F -v $refname) git rev-parse --not $other_branches | if [ -z "$custom_showrev" ] then git rev-list --pretty --stdin $revspec else git rev-list --stdin $revspec | while read onerev do eval $(printf "$custom_showrev" $onerev) done fi
This could be fixed once for all in the osgeo git script repository for all users.
Change History (5)
comment:1 by , 3 years ago
comment:2 by , 3 years ago
Upstream ticket filed to osgeo repo: https://git.osgeo.org/gitea/sac/git-hookscripts/issues/1
comment:3 by , 3 years ago
Upstream script should be fixed now. Will leave this open until I see a proof of it working
comment:4 by , 3 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Confirmed it works again: https://lists.osgeo.org/pipermail/postgis-tickets/2021-July/023868.html
comment:5 by , 3 years ago
I spoke too early. Things are all good if developers push to the "main" branch, but if they push to the "master" branch then the commit email won't contain the changes: https://lists.osgeo.org/pipermail/postgis-tickets/2021-July/023872.html
Please please please developers use the main branch
See also https://trac.osgeo.org/geos/ticket/1120