Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4970 closed defect (wontfix)

GEOS 3.9 regress failures on PostGIS 2.5

Reported by: robe Owned by: pramsey
Priority: critical Milestone: PostGIS 2.5.6
Component: postgis Version: 2.5.x -- EOL
Keywords: Cc:

Description

The freeBSD project released GEOS 3.9.1 which means the bessies bessie32 / bessie are trying to test PostGIS 2.5 against GEOS 3.9 and no surprise they are failing miserably.

So options are to stop testing freebsd on 2.5 or back port GEOS 3.9 regression fixes.

I'm leaning toward backporting the GEOS 3.9 to 2.5, as I think a lot of developers might fall into this boat.

18:20:41 PATH is /usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin:/usr/local:/usr/local/lib:/usr/local/bin
18:20:41 Checking for shp2pgsql ... found
18:20:41 Checking for pgsql2shp ... found
18:20:41 Checking for raster2pgsql ... found
18:20:41 TMPDIR is /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b
18:20:41 Creating database 'postgis_reg' 
18:20:41 Preparing db 'postgis_reg' using: CREATE EXTENSION postgis
18:20:43 Preparing db 'postgis_reg' using: CREATE EXTENSION postgis_sfcgal
18:20:45 PostgreSQL 12.7 on amd64-portbld-freebsd12.2, compiled by FreeBSD clang version 10.0.1 (git@github.com:llvm/llvm-project.git llvmorg-10.0.1-0-gef32c611aa2), 64-bit
18:20:45   Postgis 2.5.6dev - r - 2021-08-15 22:11:04
18:20:45   scripts 2.5.6dev r0
18:20:45   raster scripts 2.5.6dev r0
18:20:45   GEOS: 3.9.1-CAPI-1.14.2
18:20:45   PROJ: Rel. 7.2.1, January 1st, 2021
18:20:45   SFCGAL: 1.3.8
18:20:45   GDAL: GDAL 3.2.1, released 2020/12/29

-- below tests failing

-- this one is a little troubling as I dont' recall having to make any changes to concavehull tests
18:21:37  concave_hull_hard .. failed (diff expected obtained: /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_35_diff)
18:24:05 -----------------------------------------------------------------------------
18:24:05 --- concave_hull_hard_expected	2021-08-15 18:10:52.152402000 -0400
18:24:05 +++ /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_35_out	2021-08-15 18:22:53.520382000 -0400
18:24:05 @@ -2,4 +2,4 @@
18:24:05  ST_ConcaveHull Lines 0.80|t|t
18:24:05  ST_ConcaveHull Lines 0.80 holes|t|t
18:24:05  #3638|t|t
18:24:05 -#3697|t|t
18:24:05 +#3697|f|t
18:24:05 ----------------------------------------------------------------------------
18:24:22  regress_ogc .. failed (diff expected obtained: /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_72_diff)
18:24:22 -----------------------------------------------------------------------------
18:24:22 --- regress_ogc_expected	2021-08-15 18:10:52.215569000 -0400
18:24:22 +++ /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_72_out	2021-08-15 18:23:11.013382000 -0400
18:24:22 @@ -91,7 +91,7 @@
18:24:22  intersection|POINT(0 0)
18:24:22  difference|MULTILINESTRING((0 10,0 2),(0 -2,0 -10))
18:24:22  boundary|MULTILINESTRING((0 0,0 10,10 10,10 0,0 0),(2 2,2 4,4 4,4 2,2 2))
18:24:22 -symdifference|GEOMETRYCOLLECTION(LINESTRING(2 2,4 4),LINESTRING(10 10,20 20),POLYGON((0 0,0 10,10 10,10 0,0 0),(4 4,2 4,2 2,4 2,4 4)))
18:24:22 +symdifference|GEOMETRYCOLLECTION(POLYGON((0 10,10 10,10 0,0 0,0 10),(2 4,2 2,4 2,4 4,2 4)),LINESTRING(2 2,4 4),LINESTRING(10 10,20 20))
18:24:22  issimple|t
18:24:22  equals|t
18:24:22  pointonsurface|t
18:24:22 @@ -107,7 +107,7 @@
18:24:22  intersects|f
18:24:22  ST_GeometryN|LINESTRING(0 0,1 1)
18:24:22  ST_NumGeometries|1
18:24:22 -ST_Union1|POLYGON((0 0,0 1,0.5 1,0.5 1.5,1.5 1.5,1.5 0.5,1 0.5,1 0,0 0))
18:24:22 +ST_Union1|POLYGON((0 1,0.5 1,0.5 1.5,1.5 1.5,1.5 0.5,1 0.5,1 0,0 0,0 1))
18:24:22  ST_StartPoint1|POINT(0 0)
18:24:22  ST_EndPoint1|POINT(2 2)
18:24:22  ST_PointN1|POINT(1 1)
18:24:22 -----------------------------------------------------------------------------


18:24:28  tickets .. failed (diff expected obtained: /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_96_diff)
18:24:30 -----------------------------------------------------------------------------
18:24:30 --- tickets_expected	2021-08-15 18:10:52.358418000 -0400
18:24:30 +++ /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_96_out	2021-08-15 18:23:18.563244000 -0400
18:24:30 @@ -1,4 +1,4 @@
18:24:30 -#2|POLYGON((1 1,1 2,2 2,3 2,3 1,2 1,1 1))
18:24:30 +#2|POLYGON((1 2,2 2,3 2,3 1,2 1,1 1,1 2))
18:24:30  #11|0
18:24:30  WARNING:  ST_Locate_Between_Measures and ST_Locate_Along_Measure were deprecated in 2.2.0. Please use ST_LocateAlong and ST_LocateBetween
18:24:30  #21|SRID=31293;POINTM(6220.13 5337367.145 4566)
18:24:30 @@ -130,7 +130,7 @@
18:24:30  #723|f
18:24:30  #804|<gml:Point srsName="urn:ogc:def:crs:EPSG::4326"><gml:pos srsDimension="2">0 0</gml:pos></gml:Point>
18:24:30  #845|t
18:24:30 -#834|GEOMETRYCOLLECTION(POINT(0 0 5),LINESTRING(10 10 5,10 0 5))
18:24:30 +#834|GEOMETRYCOLLECTION(LINESTRING(10 10 4,10 0 5),POINT(0 0 5))
18:24:30  #884|1|f
18:24:30  #884|2|t
18:24:30  #938|
18:24:30 @@ -254,7 +254,7 @@
18:24:30  #2412|LINESTRING(0 0,10 0,20 0)
18:24:30  #2420.1|LINESTRING(0 0,10 0,10 10,0 10,0 0)
18:24:30  #2420.2|LINESTRING(0 0,10 0,10 10,0 10)
18:24:30 -#2423|POLYGON((-10 0,-9.2388 3.82683,-7.07107 7.07107,-3.82683 9.2388,0 10,3.82683 9.2388,7.07107 7.07107,9.2388 3.82683,10 0,-10 0))
18:24:30 +#2423|POLYGON((-9.80785 1.9509,-8.3147 5.5557,-5.5557 8.3147,-1.9509 9.80785,1.9509 9.80785,5.5557 8.3147,8.3147 5.5557,9.80785 1.9509,10 0,-10 0,-9.80785 1.9509))
18:24:30  #2424|MULTILINESTRING((0 0,10 0,24 3,30 10))
18:24:30  #2427|POINT(-1 0)
18:24:30  #2168|5340.76237395|5340.76237395|0
18:24:30 -----------------------------------------------------------------------------

18:24:53  unaryunion .. failed (diff expected obtained: /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_113_diff)
18:24:53 -----------------------------------------------------------------------------
18:24:53 --- unaryunion_expected	2021-08-15 18:10:52.368293000 -0400
18:24:53 +++ /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_113_out	2021-08-15 18:23:41.783336000 -0400
18:24:53 @@ -1,3 +1,3 @@
18:24:53  1|MULTILINESTRING((0 0,5 0),(5 0,10 0),(5 -5,5 0),(5 0,5 5))
18:24:53 -2|POLYGON((10 5,10 0,0 0,0 10,5 10,5 15,15 15,15 5,10 5))
18:24:53 -3|GEOMETRYCOLLECTION(POINT(-5 4),LINESTRING(2 -10,2 0),LINESTRING(2 10,2 20),POLYGON((10 5,10 0,2 0,0 0,0 10,2 10,5 10,5 15,15 15,15 5,10 5)))
18:24:53 +2|POLYGON((10 0,0 0,0 10,5 10,5 15,15 15,15 5,10 5,10 0))
18:24:53 +3|GEOMETRYCOLLECTION(POINT(-5 4),POLYGON((2 0,0 0,0 10,2 10,5 10,5 15,15 15,15 5,10 5,10 0,2 0)),LINESTRING(2 -10,2 0),LINESTRING(2 10,2 20))
18:24:53 -----------------------------------------------------------------------------
18:24:53  clean .. failed (diff expected obtained: /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_114_diff)
18:24:54 -----------------------------------------------------------------------------
18:24:54 --- clean_expected	2021-08-15 18:10:52.151356000 -0400
18:24:54 +++ /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_114_out	2021-08-15 18:23:42.853320000 -0400
18:24:54 @@ -27,5 +27,5 @@
18:24:54  PG|4|t|t|f
18:24:54  PG|5|t|t|f
18:24:54  #1719.1|POINT(0 0)
18:24:54 -#1719.2|GEOMETRYCOLLECTION(POINT(0 0),MULTIPOINT(3 4,5 2),POINT(4 4),MULTIPOLYGON(((0 0,5 5,10 0,0 0)),((5 5,0 10,10 10,5 5))))
18:24:54 +#1719.2|GEOMETRYCOLLECTION(POINT(0 0),MULTIPOINT(3 4,5 2),POINT(4 4),MULTIPOLYGON(((5 5,10 0,0 0,5 5)),((0 10,10 10,5 5,0 10))))
18:24:54  #1719.3|MULTIPOINT(3 4,5 2)
18:24:54 -----------------------------------------------------------------------------

18:26:04  mvt .. failed (diff expected obtained: /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_127_diff)
18:26:33 -----------------------------------------------------------------------------
18:26:33 --- mvt_expected	2021-08-15 18:10:52.182738000 -0400
18:26:33 +++ /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_127_out	2021-08-15 18:25:22.195001000 -0400
18:26:33 @@ -1,11 +1,11 @@
18:26:33  PG1|POINT(1 4094)
18:26:33  PG2|POINT(0 4095)
18:26:33  PG3|POINT(2 4092)
18:26:33 -PG4|MULTIPOLYGON(((5 4096,10 4091,10 4096,5 4096)),((5 4096,0 4101,0 4096,5 4096)))
18:26:33 +PG4|MULTIPOLYGON(((10 4096,5 4096,10 4091,10 4096)),((0 4096,5 4096,0 4101,0 4096)))
18:26:33  PG5|
18:26:33  PG6|POLYGON((2791 594,894 2704,600 594,2791 594))
18:26:33  PG7|t
18:26:33 -PG8|MULTIPOLYGON(((5 4096,10 4091,10 4096,5 4096)),((5 4096,0 4101,0 4096,5 4096)))
18:26:33 +PG8|MULTIPOLYGON(((10 4096,5 4096,10 4091,10 4096)),((0 4096,5 4096,0 4101,0 4096)))
18:26:33  PG9|16777216
18:26:33  PG9.1|2|12.5|f
18:26:33  PG10|
18:26:33 @@ -45,7 +45,7 @@
18:26:33  PG42 - ON |LINESTRING(0 10,0 0,1 0)
18:26:33  PG42 - OFF|LINESTRING(0 10,0 0,1 0)
18:26:33  PG43 - ON |MULTIPOLYGON(((5 5,0 0,10 0,5 5)),((5 5,10 10,0 10,5 5)))
18:26:33 -PG43 - OFF|MULTIPOLYGON(((5 5,-1 -1,11 -1,5 5)),((5 5,11 11,-1 11,5 5)))
18:26:33 +PG43 - OFF|MULTIPOLYGON(((11 -1,5 5,-1 -1,11 -1)),((-1 11,5 5,11 11,-1 11)))
18:26:33  PG44|
18:26:33  PG45|
18:26:33  PG46|SRID=3857;POLYGON((3262 2030,3253 2158,3245 2224,3262 2030))

18:26:33 -#4348Clip|t
18:26:33 +#4348Clip|f

18:26:36  sfcgal/regress_ogc_prep .. ok 
18:26:37  sfcgal/regress_ogc .. failed (diff expected obtained: /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_135_diff)
18:26:37 -----------------------------------------------------------------------------
18:26:37 --- sfcgal/regress_ogc_expected	2021-08-15 18:10:52.230380000 -0400
18:26:37 +++ /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_135_out	2021-08-15 18:25:25.843214000 -0400
18:26:37 @@ -91,7 +91,7 @@
18:26:37  intersection|POINT(0 0)
18:26:37  difference|MULTILINESTRING((0 -2,0 -10),(0 10,0 2))
18:26:37  boundary|MULTILINESTRING((0 0,0 10,10 10,10 0,0 0),(2 2,2 4,4 4,4 2,2 2))
18:26:37 -symdifference|GEOMETRYCOLLECTION(LINESTRING(2 2,4 4),LINESTRING(10 10,20 20),POLYGON((0 0,0 10,10 10,10 0,0 0),(4 4,2 4,2 2,4 2,4 4)))
18:26:37 +symdifference|GEOMETRYCOLLECTION(POLYGON((0 10,10 10,10 0,0 0,0 10),(2 4,2 2,4 2,4 4,2 4)),LINESTRING(2 2,4 4),LINESTRING(10 10,20 20))

18:26:37 -ST_Union1|POLYGON((0 0,0 1,0.5 1,0.5 1.5,1.5 1.5,1.5 0.5,1 0.5,1 0,0 0))
18:26:37 +ST_Union1|POLYGON((0 1,0.5 1,0.5 1.5,1.5 1.5,1.5 0.5,1 0.5,1 0,0 0,0 1))
18:26:37  ST_StartPoint1|POINT(0 0)
18:26:37  ST_EndPoint1|POINT(2 2)
18:26:37  ST_PointN1|POINT(1 1)
18:26:37 -----------------------------------------------------------------------------
18:26:37  sfcgal/regress .. ok 
18:26:37  sfcgal/tickets .. failed (diff expected obtained: /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_137_diff)
18:26:39 -----------------------------------------------------------------------------
18:26:39 --- sfcgal/tickets_expected	2021-08-15 18:10:52.231601000 -0400
18:26:39 +++ /home/jenkins/tmp/pgis_reg_d0d82e6b16bf2756e49c390d82a7ec80ca69ee5b/test_137_out	2021-08-15 18:25:27.550356000 -0400
18:26:39 @@ -1,4 +1,4 @@
18:26:39 -#2|POLYGON((1 1,1 2,2 2,3 2,3 1,2 1,1 1))
18:26:39 +#2|POLYGON((1 2,2 2,3 2,3 1,2 1,1 1,1 2))
18:26:39  #11|0
18:26:39  WARNING:  ST_Locate_Between_Measures and ST_Locate_Along_Measure were deprecated in 2.2.0. Please use ST_LocateAlong and ST_LocateBetween
18:26:39  #21|SRID=31293;POINTM(6220.13 5337367.145 4566)
18:26:39 -----------------------------------------------------------------------------

Change History (3)

comment:1 by pramsey, 3 years ago

Ugh, that's a pile of work just to pass regressions.

comment:2 by robe, 3 years ago

Resolution: wontfix
Status: newclosed

Okay you are for the screw it group. Let's quietly close this before strk notices :) I can stop testing 2.5 on FreeBSD then. Given the speed at which FreeBSD EOL's there versions and jump at upgrading GEOS (yikes I can't get a lower GEOS if I wanted to probably and too lazy to compile my own on FreeBSD). Running with a PostGIS 2.5 is probably not supported on newer versions anyway.

comment:3 by Regina Obe <lr@…>, 3 years ago

In 6c881e4/git:

Stop testing FreeBSD on 2.5 as they fail because of running GEOS 3.9. References #4970

Note: See TracTickets for help on using tickets.