Opened 3 years ago

Closed 3 years ago

#4998 closed defect (fixed)

garden tests not testing sect2 functions

Reported by: robe Owned by: robe
Priority: medium Milestone: PostGIS 3.2.0
Component: postgis Version: 2.5.x -- EOL
Keywords: Cc:

Description

I was trying to figure out why I'm missing testing so many functions in the garden tests. I realize now it's because of the reorg of docs a while back breaking the output functions into sect2s. AS a result none of the output functions have been tested recently.

I'm testing now to see if it crashes anything before I commit the change. Also to catch issues with the aggs we ran into with OVER, I'm changing all the aggs (in addition to the window ones) to test with an OVER() clause.

Change History (5)

comment:1 by robe, 3 years ago

Milestone: PostGIS 3.2.0PostGIS 3.0.5

comment:2 by Regina Obe <lr@…>, 3 years ago

In 97139b6/git:

Test functions even if not directly in sect1 section.
Put in OVER(ORDER BY random()) for all aggs and window functions.
Exclude ST_AsMVT and ST_AsFlatGeobuf for now since they have known
crashers. Until fixed.
References #4998 for PostGIS 3.2.

comment:3 by robe, 3 years ago

Forgot to note I put back testing of ST_AsFlatGeobuf in [25dc016f86/git] after #4999 was fixed

comment:4 by robe, 3 years ago

I also had put back the testing on ST_AsMVT and berrie64 is crashing. Which is odd she is the only one since I thought we had other CI bots doing garden tests.

I'll close this once ST_AsMVT is fixed and I've backported the sect2 testing to 3.1 and 3.0

comment:5 by robe, 3 years ago

Milestone: PostGIS 3.0.5PostGIS 3.2.0
Resolution: fixed
Status: assignedclosed

okay this is fixed already

Note: See TracTickets for help on using tickets.