Opened 3 years ago

Closed 3 years ago

#5012 closed defect (fixed)

Regress on tickets and buffer_params for GEOS 3.10+

Reported by: robe Owned by: pramsey
Priority: blocker Milestone: PostGIS 3.2.0
Component: postgis Version: master
Keywords: Cc:

Description

PostgreSQL 11.12, compiled by Visual C++ build 1914, 64-bit
  Postgis 3.2.0dev - (3.2.0alpha1-50-gb02b7bf7b) - 2021-10-16 19:15:57
  scripts 3.2.0dev 3.2.0alpha1-50-gb02b7bf7b
  raster scripts 3.2.0dev 3.2.0alpha1-50-gb02b7bf7b
  GEOS: 3.10.0beta3-CAPI-1.16.0
  PROJ: 7.1.1
  SFCGAL: 1.4.0
  GDAL: GDAL 3.2.3, released 2021/04/27


 ./regress/core/regress_buffer_params .. failed (diff expected obtained: /projects/postgis/tmp/3.2.0dev_pg11_geos3.10_gdal3.2.3w64/test_46_diff)
-----------------------------------------------------------------------------
--- ./regress/core/regress_buffer_params_expected	2021-10-16 14:57:43.594235200 -0400
+++ /projects/postgis/tmp/3.2.0dev_pg11_geos3.10_gdal3.2.3w64/test_46_out	2021-10-16 16:00:24.439547700 -0400
@@ -1,4 +1,4 @@
-point quadsegs=2|POLYGON((1 0,0.7071 -0.7071,1.6155e-15 -1,-0.7071 -0.7071,-1 -3.2311e-15,-0.7071 0.7071,-4.6246e-15 1,0.7071 0.7071,1 0))
+point quadsegs=2|POLYGON((1 0,0.7071 -0.7071,6.123e-17 -1,-0.7071 -0.7071,-1 -1.2246e-16,-0.7071 0.7071,-1.8369e-16 1,0.7071 0.7071,1 0))
 line quadsegs=2|POLYGON((10 2,11.414 1.414,12 0,11.414 -1.414,10 -2,0 -2,-1.414 -1.414,-2 2.449e-16,-1.414 1.414,0 2,10 2))
 line quadsegs=2 endcap=flat|POLYGON((10 2,10 -2,0 -2,0 2,10 2))
 line quadsegs=2 endcap=butt|POLYGON((10 2,10 -2,0 -2,0 2,10 2))
--------------------------------------------------------------------------

/tmp/3.2.0dev_pg11_geos3.10_gdal3.2.3w64/test_81_diff)
-----------------------------------------------------------------------------
--- ./regress/core/tickets_expected	2021-10-16 14:57:48.640534100 -0400
+++ /projects/postgis/tmp/3.2.0dev_pg11_geos3.10_gdal3.2.3w64/test_81_out	2021-10-16 16:06:54.024173000 -0400
@@ -91,7 +91,7 @@
 #835.11|MULTILINESTRING EMPTY
 #835.12|MULTIPOLYGON EMPTY
 #650|MULTIPOINT(0 0,1 1,2 2)
-#667|SRID=4326;CURVEPOLYGON(CIRCULARSTRING(30 40,-50 39.99999999999987,30 40))
+#667|SRID=4326;CURVEPOLYGON(CIRCULARSTRING(30 40,-50 39.99999999999999,30 40))
 #677.deprecated|1121395
 #677|1121395
 #680|01d107000000000000000024c000000000000049400000000000000040
-----------------------------------------------------------------------------

I just noticed debbie was set to run against 3.9 so if it was a 3.10 issue she wasn't testing. Checking on her. That said not sure why winnie isn't at rc2. Will retest on newly released 3.10 to see if still and issue.

Change History (5)

comment:1 by robe, 3 years ago

Component: buildbotspostgis
Owner: changed from robe to pramsey

Okay debbie ain't happy either after I flipped her to her GEOS master branch.

Same errors:

18:10:32   Postgis 3.2.0dev - (3.2.0alpha1-50-gb02b7bf7b) - 2021-10-20 22:06:18
18:10:32   scripts 3.2.0dev 3.2.0alpha1-50-gb02b7bf7b
18:10:32   raster scripts 3.2.0dev 3.2.0alpha1-50-gb02b7bf7b
18:10:32   GEOS: 3.11.0dev-CAPI-1.16.0
18:10:32   PROJ: 7.2.1
18:10:32   SFCGAL: 1.3.8
18:10:32   GDAL: GDAL 3.2.3, released 2021/04/27
18:10:32 


18:10:38 -----------------------------------------------------------------------------
18:10:38 --- ./regress/core/regress_buffer_params_expected	2020-12-16 21:48:07.407170106 +0000
18:10:38 +++ /var/lib/jenkins/workspace/postgis/tmp/3_2_pg9.6w64/test_46_out	2021-10-20 22:10:38.970622243 +0000
18:10:38 @@ -1,4 +1,4 @@
18:10:38 -point quadsegs=2|POLYGON((1 0,0.7071 -0.7071,1.6155e-15 -1,-0.7071 -0.7071,-1 -3.2311e-15,-0.7071 0.7071,-4.6246e-15 1,0.7071 0.7071,1 0))
18:10:38 +point quadsegs=2|POLYGON((1 0,0.7071 -0.7071,6.1232e-17 -1,-0.7071 -0.7071,-1 -1.2246e-16,-0.7071 0.7071,-1.837e-16 1,0.7071 0.7071,1 0))
18:10:38  line quadsegs=2|POLYGON((10 2,11.414 1.414,12 0,11.414 -1.414,10 -2,0 -2,-1.414 -1.414,-2 2.449e-16,-1.414 1.414,0 2,10 2))
18:10:38  line quadsegs=2 endcap=flat|POLYGON((10 2,10 -2,0 -2,0 2,10 2))
18:10:38  line quadsegs=2 endcap=butt|POLYGON((10 2,10 -2,0 -2,0 2,10 2))
18:10:38 -----------------------------------------------------------------------------

18:10:51  ./regress/core/tickets .. failed (diff expected obtained: /var/lib/jenkins/workspace/postgis/tmp/3_2_pg9.6w64/test_81_diff)
18:10:54 -----------------------------------------------------------------------------
18:10:54 --- ./regress/core/tickets_expected	2021-10-04 22:41:27.133888518 +0000
18:10:54 +++ /var/lib/jenkins/workspace/postgis/tmp/3_2_pg9.6w64/test_81_out	2021-10-20 22:10:54.106152323 +0000
18:10:54 @@ -91,7 +91,7 @@
18:10:54  #835.11|MULTILINESTRING EMPTY
18:10:54  #835.12|MULTIPOLYGON EMPTY
18:10:54  #650|MULTIPOINT(0 0,1 1,2 2)
18:10:54 -#667|SRID=4326;CURVEPOLYGON(CIRCULARSTRING(30 40,-50 39.99999999999987,30 40))
18:10:54 +#667|SRID=4326;CURVEPOLYGON(CIRCULARSTRING(30 40,-50 39.99999999999999,30 40))
18:10:54  #677.deprecated|1121395
18:10:54  #677|1121395
18:10:54  #680|01d107000000000000000024c000000000000049400000000000000040
18:10:54 -----------------------------------------------------------------------------

comment:2 by robe, 3 years ago

Milestone: PostGIS 3.2.0PostGIS 3.1.5
Summary: winnie ticket rounding regress on tickets and buffer_paramsRegress on tickets and buffer_params for GEOS 3.10+

comment:3 by Regina Obe <lr@…>, 3 years ago

In ad775f15/git:

Fix regress caused by rounding differences
between GEOS 3.10 and older GEOS
References #5012 for PostGIS 3.2.0

comment:4 by robe, 3 years ago

Milestone: PostGIS 3.1.5PostGIS 3.2.0

Didn't notice pramsey had already done this for 3.1 branch at [ec7f996bc9537919ea900f2517ab6ceae78c2b70/git] and we did slightly differently. I will update with his changes to keep in sync.

comment:5 by Regina Obe <lr@…>, 3 years ago

Resolution: fixed
Status: newclosed

In d1e8418/git:

Revise to agree with 3.1 branch. Closes #5012 for PostGIS 3.2.0

Note: See TracTickets for help on using tickets.