Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#5054 closed defect (fixed)

make check fails to fully check upgrades

Reported by: strk Owned by: strk
Priority: medium Milestone: PostGIS 3.3.0
Component: build Version: 3.2.x
Keywords: Cc:

Description

When make check is run without setting RUNTESTFLAGS=--upgrade, a rule will additionally also execute an upgrade test but such test will NOT include before/after upgrade hooks, which in turn fails to catch some upgrade errors.

Refer to ​https://trac.osgeo.org/postgis/ticket/5046?cnum_edit=13#comment:13 for an example of this false negative testrun currently performed by github actions.

Change History (4)

comment:1 by Sandro Santilli <strk@…>, 3 years ago

Resolution: → fixed
Status: new → closed

In 0b2a78d8/git:

Include internal RUNTESTFLAGS when testing upgrades

Fixes #5054

comment:2 by Sandro Santilli <strk@…>, 3 years ago

In 6a802d8/git:

Include internal RUNTESTFLAGS when testing upgrades

Fixes #5054

comment:3 by Sandro Santilli <strk@…>, 3 years ago

In 6a802d8/git:

Include internal RUNTESTFLAGS when testing upgrades

Fixes #5054

comment:4 by Sandro Santilli <strk@…>, 3 years ago

In 5082e5f/git:

Include internal RUNTESTFLAGS when testing upgrades

Fixes #5054 in 3.2 branch (3.2.1dev)

Note: See TracTickets for help on using tickets.