Opened 3 years ago

Last modified 17 months ago

#5128 new task

Integrate tiger_geocoder tests to `make check` rule

Reported by: strk Owned by: robe
Priority: medium Milestone: PostGIS 3.5.0
Component: tiger geocoder Version: master
Keywords: Cc:

Description

I see tests under extras/tiger_geocoder/regress and I see --tiger switch support in run_test.pl (partial, as it ONLY works with --extension) but I don't see tiger tests being ever run by make check

Change History (4)

comment:1 by robe, 3 years ago

Those can't be included in run_test.pl. The only tests that can be included are the ones in extensions/postgis_tiger_geocoder/sql folder that start with test-

The ones in extras require tiger data to be loaded before they'll work.

comment:2 by strk, 3 years ago

Do we need those tests to also integrate with PGXS or is it ok to rename them to match postgis core (ie: regress/ and _expected) ?

comment:3 by robe, 2 years ago

Milestone: PostGIS 3.3.0PostGIS 3.4.0

comment:4 by robe, 17 months ago

Milestone: PostGIS 3.4.0PostGIS 3.5.0
Note: See TracTickets for help on using tickets.