Opened 3 years ago

Closed 3 years ago

#5130 closed defect (fixed)

installcheck rule runs topology tests twice (second time without --extension)

Reported by: strk Owned by: strk
Priority: medium Milestone: PostGIS 3.3.0
Component: build Version: master
Keywords: Cc:

Description

Running make installcheck seems to be running run_test.pl twice: once with --extension and once (only under topology/) without --extension

Change History (4)

comment:1 by strk, 3 years ago

Version: 3.2.x → master

stable-3.2 seems to be unaffected (it runs tests 3 times but always with --extension, the additional 2 times it is for testing upgrades via function and via ALTER EXTENSION)

comment:2 by strk, 3 years ago

I found the problem being make installcheck RUNTESTFLAGS=-v as NOT passing a RUNTESTFLAGS is not a problem in master branch either. With RUNTESTFLAGS=-v passed, not only --extension disappears, but also --upgrade and --upgrade-path.

comment:3 by strk, 3 years ago

Ok the problem is in a difference between RUNTESTFLAGS passed as an env variable vs. passed as an argument to make. Things work when passed as env variable, do not when passed as an argument to make. Proposed fix: ​https://gitlab.com/postgis/postgis/-/merge_requests/81

comment:4 by Sandro Santilli <strk@…>, 3 years ago

Resolution: → fixed
Status: new → closed

In c49ab54/git:

Fix handling of RUNTESTFLAGS make argument with installcheck

Closes #5130

Note: See TracTickets for help on using tickets.