msys mingw64 Github Action is failing

[robe]

The msys GHA was taken out a couple of days ago because it started failing.

It seems to be perhaps a change upstream (perhaps a g++ change), since only changes to the regular ci.yml happened before it started failing.

Here is first failure: ​https://github.com/postgis/postgis/runs/7062499864?check_suite_focus=true

make[2]: Entering directory '/d/a/postgis/postgis/deps/flatgeobuf'
gcc -std=c++11 -x c++ -I../../liblwgeom -I../../liblwgeom -I./include  -I/mingw64/include -ID:/a/_temp/msys64/mingw64/include   -ID:/a/_temp/msys64/mingw64/include/libxml2 -I/mingw64/include -ID:/a/_temp/msys64/mingw64/include -ID:/a/_temp/msys64/mingw64/include/json-c  -ID:/a/_temp/msys64/mingw64/include  -DNDEBUG    -DDLL_EXPORT -DPIC -c -o flatgeobuf_c.o flatgeobuf_c.cpp
In file included from ./include/flatbuffers/base.h:237,
                 from ./include/flatbuffers/array.h:20,
                 from ./include/flatbuffers/flatbuffers.h:22,
                 from feature_generated.h:7,
                 from flatgeobuf_c.cpp:26:
D:/a/_temp/msys64/mingw64/include/absl/strings/string_view.h:52:26: error: 'string_view' in namespace 'std' does not name a type
   52 | using string_view = std::string_view;
      |                          ^~~~~~~~~~~
D:/a/_temp/msys64/mingw64/include/absl/strings/string_view.h:52:21: note: 'std::string_view' is only available from C++17 onwards
   52 | using string_view = std::string_view;
      |                     ^~~
D:/a/_temp/msys64/mingw64/include/absl/strings/string_view.h:692:8: error: 'string_view' does not name a type
  692 | inline string_view ClippedSubstr(string_view s, size_t pos,
      |        ^~~~~~~~~~~
D:/a/_temp/msys64/mingw64/include/absl/strings/string_view.h:703:11: error: 'string_view' does not name a type
  703 | constexpr string_view NullSafeStringView(const char* p) {
      |           ^~~~~~~~~~~
./include/flatbuffers/base.h:239:23: error: 'string_view' in namespace 'absl' does not name a type
  239 |         typedef absl::string_view string_view;
      |                       ^~~~~~~~~~~
In file included from ./include/flatbuffers/flatbuffer_builder.h:30,
                 from ./include/flatbuffers/flatbuffers.h:27:
./include/flatbuffers/string.h:31:16: error: 'string_view' in namespace 'flatbuffers' does not name a type
   31 |   flatbuffers::string_view string_view() const {
      |                ^~~~~~~~~~~
./include/flatbuffers/string.h:57:28: error: 'string_view' in namespace 'flatbuffers' does not name a type
   57 | static inline flatbuffers::string_view GetStringView(const String *str) {
      |                            ^~~~~~~~~~~
./include/flatbuffers/flatbuffer_builder.h:495:44: error: 'flatbuffers::string_view' has not been declared
  495 |   Offset<String> CreateString(flatbuffers::string_view str) {
      |                                            ^~~~~~~~~~~
./include/flatbuffers/flatbuffer_builder.h:550:56: error: 'string_view' in namespace 'flatbuffers' does not name a type
  550 |   Offset<String> CreateSharedString(const flatbuffers::string_view str) {
      |                                                        ^~~~~~~~~~~
./include/flatbuffers/flatbuffer_builder.h: In member function 'flatbuffers::Offset<flatbuffers::String> flatbuffers::FlatBufferBuilder::CreateString(int)':
./include/flatbuffers/flatbuffer_builder.h:496:29: error: request for member 'data' in 'str', which is of non-class type 'int'
  496 |     return CreateString(str.data(), str.size());

[landry]

Fwiw, there's a similar build failure on OpenBSD since an update to abseil-cpp, which is picked as a hidden dependency of flatgeobuf if found during build when using c++11, and the build fails.

                                                                                                                                                                                      
gmake[3]: Entering directory '/tmp/pobj/postgis-3.3.2/postgis-3.3.2/deps/flatgeobuf'                                                                                                  
cc -std=c++11 -x c++ -I../../liblwgeom -I../../liblwgeom -I./include  -I/usr/local/include -I/usr/lo                                                                                  
cal/include -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include  -I/usr/local/inc                                                                                  
lude -I/usr/local/include/json-c -I/usr/local/include -DNDEBUG -I/usr/local/include -O2 -pipe  -fPIC                                                                                  
 -DPIC -c -o flatgeobuf_c.o flatgeobuf_c.cpp                                                                                                                                          
In file included from flatgeobuf_c.cpp:26:                                                                                                                                            
In file included from ./feature_generated.h:7:                                                                                                                                        
In file included from ./include/flatbuffers/flatbuffers.h:22:                                                                                                                         
In file included from ./include/flatbuffers/array.h:20:                                                                                                                               
In file included from ./include/flatbuffers/base.h:237:                                                                                                                               
In file included from /usr/local/include/absl/strings/string_view.h:39:                                                                                                               
In file included from /usr/local/include/absl/base/attributes.h:37:                                                                                                                   
In file included from /usr/local/include/absl/base/config.h:86:                                                                                                                       
/usr/local/include/absl/base/policy_checks.h:79:2: error: "C++ versions less than C++14 are not supported."                                                                           
#error "C++ versions less than C++14 are not supported."    

that's a similar problem as seen in mapserver, cf ​https://github.com/MapServer/MapServer/issues/6822

[robe]

Thanks for the heads up on that.