Opened 2 years ago

Closed 2 years ago

#5260 closed defect (fixed)

geos310 failure against GEOS main (3.12dev)

Reported by: robe Owned by: robe
Priority: blocker Milestone: PostGIS 3.4.0
Component: postgis Version: master
Keywords: Cc:

Description

Both winnie and debbie are showing this regress failure when testing against GEOS main 

Debbie
16:08:25   GEOS: 3.12.0dev-CAPI-1.18.0
16:08:25   PROJ: 7.2.1
16:08:25   SFCGAL: 1.3.8
16:08:25   GDAL: GDAL 3.4.3, released 2022/04/22

winnie
PostgreSQL 15.0, compiled by Visual C++ build 1914, 64-bit
  Postgis 3.4.0dev - (3.3.0rc2-223-g46005ff37) - 2022-10-19 00:18:42
  scripts 3.4.0dev 3.3.0rc2-223-g46005ff37
  raster scripts 3.4.0dev 3.3.0rc2-223-g46005ff37
  GEOS: 3.12.0dev-CAPI-1.18.0
  PROJ: 7.2.1
  SFCGAL: 1.4.1
  GDAL: GDAL 3.4.3, released 2022/04/22

 ./regress/core/geos310 .. failed (diff expected obtained: /projects/postgis/tmp/3.4.0dev_pg15_geos3.12_gdal3.4.3w64/test_117_diff)
-----------------------------------------------------------------------------
--- ./regress/core/geos310_expected	2022-08-27 01:02:58.508984000 -0400
+++ /projects/postgis/tmp/3.4.0dev_pg15_geos3.12_gdal3.4.3w64/test_117_out	2022-10-18 20:40:43.779910600 -0400
@@ -1 +1 @@
-#168|3|MULTIPOLYGON ZM (((4275341.969778511 259186.96699306098 1323.762958283311 -1.797693134862316e+308,4275341.969778511 259186.96699306098 1323.762958283311 -1.797693134862316e+308,4275341.969778511 259186.96699306098 1323.762958283311 -1.797693134862316e+308)))|Too few points in geometry component[4275341.96977851 259186.966993061 1323.76295828331]
+#168|3|MULTIPOLYGON ZM (((4275341.969778511 259186.96699306098 1323.762958283311 -1.797693134862316e+308,4275341.969778511 259186.96699306098 1323.762958283311 -1.797693134862316e+308,4275341.969778511 259186.96699306098 1323.762958283311 -1.797693134862316e+308)))|Too few points in geometry component[4275341.96977851 259186.966993061]
-----------------------------------------------------------------------------

Change History (6)

comment:1 by robe, 2 years ago

Just a note the difference seems to be in the error message.

GEOS main has one less coordinate in the error note 

Too few points in geometry component[4275341.96977851 259186.966993061]

Where as before

it was: 

Too few points in geometry component[4275341.96977851 259186.966993061 1323.76295828331]

comment:2 by robe, 2 years ago

Forgot to mention the test failing is: 

SELECT '#168', ST_NPoints(g), ST_AsText(g), ST_isValidReason(g)
FROM ( VALUES
('01060000C00100000001030000C00100000003000000E3D9107E234F5041A3DB66BC97A30F4122ACEF440DAF9440FFFFFFFFFFFFEFFFE3D9107E234F5041A3DB66BC97A30F4122ACEF440DAF9440FFFFFFFFFFFFEFFFE3D9107E234F5041A3DB66BC97A30F4122ACEF440DAF9440FFFFFFFFFFFFEFFF'::geometry)
) AS v(g);

I'm guessing might be caused by this commit - ​https://github.com/libgeos/geos/commit/32348a68c5212c89cfefab46891d2b3aada4ab40 which happened around same time tests started failing.

comment:3 by robe, 2 years ago

Milestone: PostGIS 3.3.2 → PostGIS GEOS

Dan said he'll fix in GEOS, wasn't intentional. ​https://lists.osgeo.org/pipermail/geos-devel/2022-October/010805.html

comment:4 by robe, 2 years ago

Owner: changed from pramsey to dbaston

comment:5 by robe, 2 years ago

Milestone: PostGIS GEOS → PostGIS 3.4.0
Owner: changed from dbaston to robe

I think geos settled on keeping the change in behavior, so I'm going to change the test

comment:6 by Regina Obe <lr@…>, 2 years ago

Resolution: → fixed
Status: new → closed

In cc846f72/git:

geos310 failure against GEOS main (3.12dev)
Closes #5260 for PostGIS 3.4.0

Note: See TracTickets for help on using tickets.